Added view to enable target selection for manual observing runs #840

rachel3834 · 2024-02-12T20:53:59Z

This feature aims to improve the TOM's useability for observers operating more traditional, block-scheduled observing facilities, often manually or through remote operations. The feature provides a form and view to enable them to easily identify targets visible at their facility on the date indicated.

…lity

tom_targets/views.py

jchate6

I've made some specific comments, that I think are important, but I have some general comments that I think will require a larger discussion.

Specifically, I'd like to talk about what you are actually looking to accomplish here. This returns a selection of targets in a list that have an airmass < 2.0 within a specific 24 hour window with 10 steps starting at YYYY-MM-DDT00:00:00 for a list of telescopes at a specific observatory. That feels like a highly specific use case that should probably be made more generalized. Users might want to change the limiting airmass, or see all of the telescopes at once, or set up their window so it encompasses a full night at CPT rather than splitting it.

Additionally, I feel like the information returned is limiting. This doesn't tell a user WHEN the target will be at it's lowest airmass, or sort them in any way or give a user an idea of how long the target will be up. Also, this is completely incompatible with non-sidereal targets.

Ultimately I'm wondering if this whole idea makes more sense being incorporated into the target list view. An airmass filter could possibly be added, and "observation planning" columns could be put on the table.

Would love to discuss further when you have time.

tom_targets/views.py

tom_targets/templates/tom_targets/target_facility_selection.html

tom_targets/forms.py

tom_targets/views.py

tom_targets/forms.py

rachel3834 · 2025-09-02T19:15:24Z

I've implemented all of the changes requested above. I take your point about the potential for more generalized functionality for this view but I think it makes sense to implement this version first before trying to generalize.

jchate6

A few things.
Mostly small. Let me know if you want to talk about the general facility module.

docs/observing/index.rst

docs/observing/selecting_targets_for_facility.rst

tom_targets/templates/tom_targets/target_facility_selection.html

tom_targets/views.py

jchate6 · 2025-09-04T22:55:56Z

docs/observing/selecting_targets_for_facility.rst

+  :alt: Target Selection table with additional columns added
+
+
+Adding An Observing Facility to the Target Selection Form


I really don't like this section.
We really don't want people making orphaned facilities in this way.

I think we can add the basics for a DB driven general facility in a sprint.
I would recommend cutting this section and prioritizing that work in the upcoming sprint. It would be a much more sustainable way to do this, and will be necessary in the long run.

I've removed this section, pending the other issue to add a General Facility model.

Having now implemented the General Facility model, and integrated it with the target selection form, I've updated this section of the documentation accordingly.

tom_targets/forms.py

tom_targets/views.py

rachel3834 · 2025-09-11T22:08:22Z

Ideally I'd like this view to present the form, plus a paginated list of results when available, but this involves combining both a FormView to handle the POST and a ListView to handle the pagination. Pushing a partial refactor with most of the comments completed in order to get advice on the best way forward.

… so as to cap the number of visibility calculations that can take place at a given time.

rachel3834 · 2025-09-13T00:24:42Z

I've refactored the FormView to implement pagination on the list of targets, and updated the get and post methods so that pagination works as intended in the template.

…ture/facility_target_selection

…calculation handling

rachel3834 · 2025-10-08T23:39:22Z

I've integrated the new general facilities model with this form for calculating target visibilities from different observatories. The easiest way to handle this was to do some refactoring of the tom_observations.utils.get_sidereal_visibility function.

jchate6

I've pointed out a few broken or problematic changes. I haven't really gotten back into the actual utility of the feature. It seems like there is some pagination issue, but I can't really tell if that's just a symptom of other problems.

tom_targets/forms.py

jchate6 · 2025-10-15T23:32:42Z

tom_targets/views.py

        return redirect(reverse('tom_targets:list') + '?' + query_string)


-class TargetGroupingView(PermissionListMixin, ListView):


I'm confused by this change.
This will break. There is no form included in the context.

This class has a FormView rather than a ListView.

I don't understand what you mean.
A FormView requires a form, and will try to return a form class.
This view has no form. So you will get a TypeError if you try to load this page.

tom_targets/views.py

tom_observations/utils.py

…idereal_visibility function

…ture/facility_target_selection

jchate6

Sorry to go another round, but I think this is looking much better!
Let me know if you have any questions.

jchate6 · 2025-11-20T18:38:09Z

tom_targets/views.py

        return redirect(reverse('tom_targets:list') + '?' + query_string)


-class TargetGroupingView(PermissionListMixin, ListView):


I don't understand what you mean.
A FormView requires a form, and will try to return a form class.
This view has no form. So you will get a TypeError if you try to load this page.

jchate6 · 2025-11-20T18:41:34Z

tom_targets/views.py

+                visibiliy_intervals, airmass_max,
+                observation_facility=request.POST.get('observatory')
+            )
+            for site, vis_data in visibility_data.items():


This works well for non-LCO facilities, but takes a very long time to load for just 100 targets at LCO and I'm not sure the table is useful.

jchate6 · 2025-11-20T19:04:51Z

tom_targets/templates/tom_targets/target_facility_selection.html

+                    <th>{{col}}</th>
+                {% endfor %}
+            </tr>
+            {% if target_visibilities|length > 0 %}


This doesn't make sense to be in the template after the pagination.
The pagination is happening in views, so the whole target list is being paginated, but only the visible targets are being displayed. This leads to many empty pages. Instead we should paginate the list of visible targets, removing the non-visible targets in views around line 960.

jchate6 · 2025-11-20T19:23:33Z

tom_targets/views.py

+    form_class = TargetSelectionForm
+    observable_targets = []
+
+    def get_context_data(self, *args, **kwargs):


We probably want to keep the form data after submitting, so it's still in the form above the table. To do this, we need to add the results of request.POST to the context data.

change this to get_context_data(self, request, *args, **kwargs):

and see other changes below.

jchate6 · 2025-11-20T19:24:17Z

tom_targets/views.py

+
+        context = super().get_context_data(*args, **kwargs)
+        # Surely this needs to verify that the user has permission?
+        context['form'] = TargetSelectionForm()


change this to context['form'] = TargetSelectionForm(request.POST or None)

To pass the form results from a post back into the form.

jchate6 · 2025-11-20T23:46:02Z

docs/observing/selecting_targets_for_facility.rst

+telescope at the target, but it can be easily extended to add further information.
+
+The columns of the table can be configured by editing the TOM's ``settings.py`` file.
+Additional parameters can be defined for each target by adding dictionary definitions


This seems confusing to me. I think we should separate the EXTRA_FIELDS conversation from the SELECTION_EXTRA_FIELDS description.

Instead, let's link them to docs/targets/target_fields.rst where they can learn how to add other fields, and then tell them how to use SELECTION_EXTRA_FIELDS

jchate6 · 2025-11-20T23:51:51Z

tom_targets/views.py

+
+                    # Extract any requested extra parameters for this object, if available
+                    for param in getattr(settings, 'SELECTION_EXTRA_FIELDS', []):
+                        if param in target.extra_fields.keys():


This should also look for fields in the Target Model itself, not just target extras.
People will be adding custom Target models for exactly this purpose.

jchate6 · 2025-11-20T23:54:16Z

docs/observing/selecting_targets_for_facility.rst

+.. image:: target_selection_table_extra_fields.png
+  :alt: Target Selection table with additional columns added
+
+.. code:: python


Is this section sill relevant? At the very least it feels non-sequitur

This should probably all be included in or a reference to docs/observing/observation_module.rst

jchate6 · 2025-11-20T23:58:05Z

docs/observing/selecting_targets_for_facility.rst

+This page can be reached by adding ``/admin/`` to the end of the TOM's root URL in your browser's navigation bar, e.g.:
+
+.. code-block:: html
+> https://demo.lco.global/admin/


Needs a blank line and an indent.

jchate6 · 2025-11-21T00:02:33Z

docs/observing/selecting_targets_for_facility.rst

+.. code-block:: html
+> https://demo.lco.global/admin/
+
+Scrolling down the list of database tables, you will find ``Facilitys`` under the tables from the ``tom_observations`` app.


Oof, no, let's fix this.

go to tom_observations.models.py

inside Facility immediately after you define the model parameters, add

class Meta: verbose_name_plural = "facilities"

rachel3834 added 9 commits February 9, 2024 16:15

First draft of form to display a target selection for a specific faci…

ecfc7fc

…lity

First working version of target selection table plus docs

70d5d9b

Removing files committed accidentally

070a1b6

Fixed code blocks in docs

9e1b042

Maximizing figure width

011537e

Fixed broken link

05d149b

Fixed broken link

ce5aa95

Fixed indentation

f4e677f

Added indicator of which file to edit

f8d76e5

rachel3834 added the enhancement New feature or request label Feb 12, 2024

rachel3834 requested review from Fingel and jchate6 February 12, 2024 20:53

rachel3834 self-assigned this Feb 12, 2024

jchate6 and others added 2 commits February 12, 2024 13:06

Merge branch 'dev' into feature/facility_target_selection

7feef59

fix linting errors

22d37bc

jchate6 linked an issue Feb 12, 2024 that may be closed by this pull request

Classical Observing Support #206

Open

jchate6 reviewed Feb 12, 2024

View reviewed changes

tom_targets/views.py Outdated Show resolved Hide resolved

phycodurus requested review from phycodurus and removed request for phycodurus February 15, 2024 21:03

jchate6 added the User Issue Raised by a user label Feb 26, 2024

jchate6 requested changes Mar 20, 2024

View reviewed changes

rachel3834 added 4 commits September 2, 2025 11:04

Resolved conflicts with current dev

c2fc5b6

Resolving commits from review

ff4b5fb

Revised view and template to provide links to target detail page

e233cb8

Fixed linting errors

8076c7c

rachel3834 requested a review from jchate6 September 2, 2025 22:30

Merge branch 'dev' into feature/facility_target_selection

729454e

phycodurus removed their request for review September 3, 2025 21:28

Merge branch 'dev' into feature/facility_target_selection

7b6b779

jchate6 requested changes Sep 4, 2025

View reviewed changes

rachel3834 added 2 commits September 11, 2025 15:03

Refactored target facility selection view

d2d35fc

Fixed conflicts

ad489a9

rachel3834 added 5 commits September 12, 2025 16:38

Refactored FormView and templates to handle pagination

c7dbb9a

Removing superfluous partial

377514d

Refactored to paginate the targets rather than the visibility results…

39bd323

… so as to cap the number of visibility calculations that can take place at a given time.

Removed section referring to adding facilities

2a10aec

Fixed linting issues

f0626f3

rachel3834 requested a review from jchate6 September 13, 2025 00:24

rachel3834 added 3 commits October 8, 2025 13:23

Merge branch 'dev' of https://github.com/TOMToolkit/tom_base into fea…

9a85621

…ture/facility_target_selection

Updated to dev

da983bc

Added general facilities to the target selection form and visibility …

9f32a32

…calculation handling

rachel3834 and others added 4 commits October 8, 2025 20:35

Linting updates

2f8f96d

Added documentation of new general facilities table

d06ba1e

Merge branch 'dev' into feature/facility_target_selection

068da97

Merge branch 'dev' into feature/facility_target_selection

4843a55

jchate6 requested changes Oct 16, 2025

View reviewed changes

rachel3834 added 4 commits November 19, 2025 13:27

Updated docs

be29224

Refactored following review; moved resolution of observatory to get_s…

6159b55

…idereal_visibility function

Updated for linting

ca09072

Merge branch 'dev' of https://github.com/TOMToolkit/tom_base into fea…

dfb19d2

…ture/facility_target_selection

rachel3834 requested a review from jchate6 November 19, 2025 23:29

jchate6 requested changes Nov 21, 2025

View reviewed changes

		:alt: Target Selection table with additional columns added


		Adding An Observing Facility to the Target Selection Form

		return redirect(reverse('tom_targets:list') + '?' + query_string)


		class TargetGroupingView(PermissionListMixin, ListView):

Added view to enable target selection for manual observing runs #840

Are you sure you want to change the base?

Added view to enable target selection for manual observing runs #840

Uh oh!

Conversation

rachel3834 commented Feb 12, 2024

Uh oh!

Uh oh!

jchate6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rachel3834 commented Sep 2, 2025

Uh oh!

jchate6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rachel3834 commented Sep 11, 2025

Uh oh!

rachel3834 commented Sep 13, 2025

Uh oh!

rachel3834 commented Oct 8, 2025

Uh oh!

jchate6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jchate6 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!