Skip to content

Fixed a reconnect bug with websockets #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Reimer merged 6 commits into from
Jan 30, 2025
Merged

Fixed a reconnect bug with websockets #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a26032
Fixed a reconnect bug with websockets
wmr-trevor Jan 30, 2025
3b6f7f3
Added no-sandbox arg
wmr-trevor Jan 30, 2025
008585e
Added chrome as browser
wmr-trevor Jan 30, 2025
b51a3dc
Added puppeteer as dependency
wmr-trevor Jan 30, 2025
1c40e9c
removed puppeteer install.
wmr-trevor Jan 30, 2025
0d30b58
Added allow-chrome-as-root
wmr-trevor Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions lib/client/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,32 +174,32 @@ function createNewConnection() {
}
});

socket.addEventListener("error", (error) => {
ready = false;
console.error(error);
stateChangeEvents.forEach(callback => callback("OPEN"));
} else {
createNewConnection();
}
});

stateChangeEvents.forEach(callback => callback("ERROR"));
});
socket.addEventListener("error", (error) => {
ready = false;
console.error(error);

socket.addEventListener("close", () => {
ready = false;
const timeout: number = typeof setOptions.reconnectTimeOut === "function" ? setOptions.reconnectTimeOut() : setOptions.reconnectTimeOut;
stateChangeEvents.forEach(callback => callback("ERROR"));
});

// wait for a little before reconnecting
if (setOptions.reconnect) {
setTimeout(createNewConnection, timeout);
}
// if the previous state wasn't auth failed then send a closed message
if (getCurrentState() !== "AUTHFAILED") {
stateChangeEvents.forEach(callback => callback("CLOSED"));
}
});
socket.addEventListener("close", () => {
ready = false;
const timeout: number = typeof setOptions.reconnectTimeOut === "function" ? setOptions.reconnectTimeOut() : setOptions.reconnectTimeOut;

stateChangeEvents.forEach(callback => callback("OPEN"));
} else {
createNewConnection();
// wait for a little before reconnecting
if (setOptions.reconnect) {
setTimeout(createNewConnection, timeout);
}
// if the previous state wasn't auth failed then send a closed message
if (getCurrentState() !== "AUTHFAILED") {
stateChangeEvents.forEach(callback => callback("CLOSED"));
}
})
});
}

/**
Expand Down
Loading