Open
Conversation
Owner
|
Ignoring TLS certificates validation is generally not recommended, but can have use in some scenarios, like testing. Therefore I can allow it, but it should not be default. I would say the best approach is to add another boolean parameter to the ctx.check_hostname = False
ctx.verify_mode = ssl.CERT_NONEonly if someone intentionally add that parameter. |
Author
|
makes total sense. I'll work on that but it may take a bit. Thanks for input! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to bypass errors with self signed certificates.