ST6RI-901 Missing implicit specializations of objects/subobjects #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checkFeatureObjectSpecialization and checkFeatureSubobjectSpecialization for an OccurrenceUsage with a Structure type. - checkFeatureSubobjectSpecialization for a composite PortUsage explicitly typed by a PortDefinition.
So checkFeatureObjectSpecialization and checkFeatureSubobjectSpecialization are properly satisfied when they apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects missing implicit specializations of
Objects::objectsandObjects::Object::subobjectsin certain cases for port usages and occurrence usages.A nested composite port usage (i.e., a subport) explicitly typed by a port definition meets the criteria for
checkFeatureSubobjectSpecializationand, therefore, should have an implied subsetting ofObjects::Object::subobject. In particular,Ports::Port::subportsshould have this implied subsetting, so every subport should then satisfy the constraint automatically. (See also SYSML21-483.)An occurrence usage explicitly typed by a structure type (such as an item definition) meets the criteria for
checkFeatureObjectSpecialization(orcheckFeatureSubobjectSpecialization, if it is a subobject) and, therefore, should have an implied subsetting ofObjects::objects(orObjects::Object::subobjects).