Skip to content

Conversation

@bmouillon
Copy link
Collaborator

3 nouveaux algorithmes :

  • L'algorithme sans cache, adapté à MBA.
  • L'algorithme avec génération par la grammaire, adapté à MBA.
  • L'algorithme générique, adapté à n'importe quel DSL.

Copy link
Member

@Theomat Theomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add overall comments on functions on how they interact with each other?
Could you also avoid one liners for while and if, it makes it very hard to parse at a glance if everything is on one line. :)
Except from a few optimizations here and there, great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python works with infinite size integers which is a bit of a different behaviour than C's behaviour this will lead to unfeasible benchmarks in some cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add overall comments on functions on how they interact with each other?
Could you also avoid one liners for while and if, it makes it very hard to parse at a glance if everything is on one line. :)
Except from a few optimizations here and there, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants