Modernize repo and make sure it works with ST4#9
Open
Frizlab wants to merge 183 commits intoSublimeText:masterfrom
Open
Modernize repo and make sure it works with ST4#9Frizlab wants to merge 183 commits intoSublimeText:masterfrom
Frizlab wants to merge 183 commits intoSublimeText:masterfrom
Conversation
AFAICT the tests **must** be run in Sublime Using <https://github.com/SublimeText/UnitTesting> probably helps (and it can also run the tests in GitHub Actions).
Author
|
There are probably more tests we could do, but I declare the PR ready for review! \o/ |
Author
|
Oh. I forgot the Readme 😅 |
michaelblyons
requested changes
Mar 11, 2026
michaelblyons
left a comment
michaelblyons
left a comment
There was a problem hiding this comment.
Looks like good work! I have a couple metadata comments and a little bike-shedding.
Author
|
Done! Not sure it’s actually better to create the parser from the format |
10 tasks
|
Now waiting on sublimehq/package_control_channel#9333. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That being said:
I have no idea if it works before ST4 nowIt does not work before ST4;I have not succeeded in running the tests (UnitTesting shows a panel at the bottom, but it is desperately empty; I suspect a syntax error, or something of that nature, but I don’t know for sure and am not sure how to debug…)-> Fixed;I have removed the support for vim modelines. There is a dedicated plugin for that if needed; let’s not mix everything up!-> I actually enhanced the support for it, as well as added Emacs modelines;