-
Notifications
You must be signed in to change notification settings - Fork 150
Update Web Browser to 1.4.3 #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
beebls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small changes all LGTM
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s):
Has the following minor non-blocking issue(s):
SummaryI opened the plugin UI and played around with the settings. Changed the search engine and tried searching in the browser. Opened multiple tabs. Played with the menu position setting to see what it did, but couldn't tell what changed. Played around with the home page settings and found I couldn't figure out how to edit them. |
Navigate to the site you want. Press start button to open context menu, then choose
Not sure how that's possible. I couldn't reproduce.
Where the browser is listed in the main menu.
It's not possible. Web pages have to implement that themselves. On a separate note, sadly, it seems that valve have changed how the internal browser opens links. It looks like now they always open in a new window instead of navigating the page. So the links get opened outside of "Web Browser Plugin". So it looks like navigating to a desired site using a search engine isn't possible anymore, but you can still navigate to it directly via the url. |
Update Web Browser to 1.4.3
Fixes plugin not working on latest Steam.
Task Checklist
Developer
Plugin
Backend
Community
Testing