Update Junk-Store 1.1.12

[ebenbruyns]

… for future server side filtering of the RSS feed.

Update Junk-Store to 1.1.12

Fixed a bug with umu fixes causing a path not found error.

Task Checklist

Developer

• I am the original author or an authorized maintainer of this plugin.
• I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

• I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
• I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

• No: I am using a custom backend other than Python.
• No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
• No: I am using a custom binary that has all of it's dependencies statically linked.

Community

• I have tested and left feedback on two other pull requests for new or updating plugins.
• I have commented links to my testing report in this PR.

Testing

• Tested by a third party on SteamOS Stable or Beta update channel.

[github-actions]

Issues Found

No issues with your PR description were found.

Next Steps

1. If we found any issues above, please edit your pull request description to resolve them and leave a comment saying you've done so.
2. For the quickest review, please see the Community section of the pull request template for how you can help other developers.
3. Once your description is correct, a maintainer will review your pull request as soon as possible.

Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️

[EMERALD0874]

LGTM for testing

[ebenbruyns]

@EMERALD0874 is there something I need to do before this gets approved for deployment? We'd like to get on top of the testing tasks soon as we'll be travelling and that will mess with the timelines of the PR workflow.

[EMERALD0874]

It's been deployed now, sorry. Thought I got it already but may have missed it

[ebenbruyns]

Thank you, no worries. I just thought I missed something on my end.

[wheaney]

Plugin Testing Report

Installed Plugins

• XR Gaming - 1.3.0
• AutoFlatpaks - 1.6.8
• PlayCount - 1.6
• Junk-Store - 1.1.12-xxxxxxx

Specifications

• SteamOS 3.7.17 (Stable)
• Steam 1766529085 (Stable)
• Decky v3.2.1 (Stable)

Issues

Has the following major blocking issue(s):

• When the Epic Games Login "app" (Legendary is the app, I think) is open in the left-hand steam menu, the controls seem to get doubled (up/down will skip an option).
• There's no way to "sign in on your browser" from game mode. It doesn't open a browser window that I can tell.

Has the following minor non-blocking issue(s):

• No way to install a launcher other than Epic from game mode? No in-app guidance, would be nice if it at least said something like "see our help pages for adding other launchers" so you can tell if it's supported.
• Install dependencies trails the output and displays a lot of "?" as if characters are non-printable during installation, but they definitely are printable.
• Seems like maybe it only detects Epic games from its own install, not other installs. Probably working as intended.

Summary

Opened the plugin and installed dependencies. Hit the Games button and was taken to a view with an Epic tab. Tried to use the PlayStation and Nintendo login buttons and was shown a dialog that said it had opened in a browser window, but the Steam menu shows no other apps or views open. Went to desktop mode and used the login app, which succeeded in opening a Firefox tab where I could log in to PlayStation network and the Epic login was successful. Returned to Game Mode and launched the Epic view. It didn't detect games already installed from a previous Epic install but that's probably expected. Kicked off a game install and that seems to be working fine.

[ebenbruyns]

@wheaney thanks for the test report.

The blockers are not actually plugin related issues. Legendary is an external application.

The oauth login issue with browsers is actually a gamescope limitation and nothing I can do about it, I had off control to steam for the login process so I'm not even involved in it and legendary does the work there.

as for the non blockers, the FOSS version only has Epic support. Gog is a paid extension and not part of this code base. The other extensions you might have seen is part of the commercial product that's a completely separate code base and not relevant here.

The non printable characters has been there since the original release, it doesn't affect functionality and most users only do this once and never look at it again. I have found that sometimes these can be font related but honestly implementing a whole lot of stuff for just this is not really a priority and has never stopped merging before.

Only detecting games managed by the plugin is kinda the point.

I would how ever appreciate feedback on the Umu changes I made, it seems that it works properly for games now that doesn't have an UMU id, which is what this whole PR was actually about. But we have identified that there's an issue with UMU fixes for games that do have an ID. I haven't had time to sit down and investigate it yet due to it being that time of year. I'll be returning to my boat in the next few days so I'll probably have some time to look at it once I'm back in work mode.

If you could ID some games that exhibit this behaviour as test cases that would be tremendously helpful.

[wheaney]

The oauth login issue with browsers is actually a gamescope limitation and nothing I can do about it, I had off control to steam for the login process so I'm not even involved in it and legendary does the work there.

Okay, it seemed worth calling out as I was looking at the Junk Store web page and it advertises that you never need to leave game mode, but for this you do, at least as a first-time setup. And maybe if the login expires?

If you could ID some games that exhibit this behaviour as test cases that would be tremendously helpful.

Can you help me figure out what games qualify? I'm not familiar with this issue.

[ebenbruyns]

Okay, it seemed worth calling out as I was looking at the Junk Store web page and it advertises that you never need to leave game mode, but for this you do, at least as a first-time setup. And maybe if the login expires?

This is actually in the troubleshooting area of the website. It's well documented. If you don't use oauth you never leave game mode and most users use email and password. It's also not a plugin feature, this is a legendary issue (or any oauth/webview implementation).

Can you help me figure out what games qualify? I'm not familiar with this issue.

This is actually the crux of the issue. When you launch a game the first time if you get a "path not found" error, it's one that qualifies. you might be able to trawl the umu fixes db for this... but it's super time consuming to try and match ID's with the games you own. We just install games until we find one that's an issue. You can use the games tested table on the website to see the ground we have already covered.

[wheaney]

It's well documented

Someone getting a rec to use the plugin and installing it right from the store won't have scoured the documentation first. It would be ideal if the plugin sets expectations for these issues before handing off to the other app, like "some login methods require a browser and will need to be done from desktop mode," because a user isn't going to care where the line is between your ownership and a third party ("Legendary" isn't even mentioned until you go to desktop mode, it just looks like part of the junk store plugin).

just install games until we find one that's an issue

This looks like possibly a different issue, but trying to install Dragon Age Inquisition resulted in this error:

All my Epic games are from the free giveaway, so I have a lot but it looks like most are in the tested list. I tried installing Dying Light since it's not tested as far as I can tell and when I used B to go back to the games list it seemed to lose track of the install. I got a notification that an install finished but it used a hex ID and going back to Dying Light showed that it's not tracked by Junk Store, so it's still showing the Install button.

[wheaney]

Dying Light: Enhanced Edition works perfectly, that's not listed in the tested table.

[wheaney]

Elite Dangerous also worked well for me, after fighting with its launcher, that's also not in the tested list.