-
Notifications
You must be signed in to change notification settings - Fork 149
Add DeckyParty File Manager #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
My only concern is "DeckyParty" is a fairly non-descriptive name that sounds more like a gaming plugin than a file server. Have you considered any other naming options? If you're sure this is the name you like, let me know and I'll move it to testing store. |
Good Point. [UseCase]Party has been a common instance naming scheme in the Copyparty Community, that's why I didn't really give it any second thought... Should I just go with "Copyparty", "DeckyParty FileServer" or "Copyparty for Decky"? Although that last one might be too long to properly fit. |
|
@EMERALD0874 settled on DeckyParty File Manager. |
|
I noticed that the full release of copyparty itself is commited into the git repo; this means that the git-repo will grow by at least 1 megabyte every time there is a new version. Over time, this will make it really big. I'm not sure how easy the following would be to do, since it depends on how the rest of the tooling works (and I don't know anything about that), but: A better approach would be for https://github.com/39sdev/Decky-CP to include an https-link to either the latest release or a specific version -- for security, it could link a specific version and expect a particular checksum, to ensure it hasn't been tampered with. Although the benefit of using a link to the latest version would be that users could/would automatically get the latest version of copyparty, which could have relevant bugfixes included. I do try my best to not make breaking changes, so I'd like to say that using the latest version should be fine. |
|
I'll try to review this tomorrow, but 9001 raises a good point. @39sdev, you may want to check how Decky Framegen uses our remote binary system in its package.json here. Like 9001 suggested, it'll download whatever release you mention and check for a specific checksum when installing the plugin with Decky. |
|
Thanks for the reference! I've switched over to using the remote binary download system. However, providing the latest version without a plugin update would be pretty cool, especially since I doubt Copyparty will do any fundamental changes to how it's arguments are structured in the future. Would I be allowed to add a version check / update mechanism inside of the plugin? or is this strictly forbidden due to security concerns? |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
(Please don't let this die... ❤️) |
|
Not intending to. This should be ready to go in it's current state. |
EMERALD0874
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing
|
What about the pending testing_env check? |
|
Fixed, my bad |
Add DeckyParty File Manager to Plugin Store
This plugin allows users to manage their home directory & external storage via the small but immensely powerful copyparty file server.
A similar Plugin already on the Store would be DeckyFileServer,
the key advantages of DeckyParty being:
/run/media/<user>/, so that users can seemlessly manage their sd card files aswell.Task Checklist
Developer
Plugin
Backend
Community
Testing