feat(net): add netlink route support #25

Anekoique · 2025-12-04T17:46:16Z

This PR introduces support for Netlink Route, referencing the implementations of Asterinas and DragonOS.

Some Linux apps rely on simple Netlink mechanisms to retrieve link or address information. This support is crucial for adapting FastDDS and ROS 2 to Starry.

Now, Starry can run ip link show and ip addr show normally:

starry:~# ip link show
1: lo: <LOOPBACK,UP> mtu 1500 qlen 65536
    link/loopback
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qlen 65536
    link/ether
starry:~# ip addr show
1: lo: <LOOPBACK,UP> mtu 1500 qlen 65536
    link/loopback
    inet 127.0.0.1/8 scope host lo
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qlen 65536
    link/ether
    inet 10.0.2.15/24 scope host eth0

Dependencies:

This PR is based on the API from the axio PR: https://github.com/Starry-OS/axio/pull/1. Considering that axio is currently being refactored, I am opening this as a Draft. I will mark it as ready for review once the refactoring is completed.

Additional Fix (FS):

The original function is_valid checked file open flags based on std::fs::OpenOptions, which does not conform to POSIX semantics (e.g., it was unable to create read-only files), leading to failures in some programs.
I have renamed is_valid to check_options to perform simple flag checks. More comprehensive checks may need to be added later, referencing https://man7.org/linux/man-pages/man2/open.2.html.

Co-authored-by: 朝倉水希 <asakuramizu111@gmail.com>

Signed-off-by: Weikang Guo <guoweikang@kylinos.cn> Co-authored-by: Weikang Guo <guoweikang@kylinos.cn> Co-authored-by: zhangguoyu <zhangguoyu@kylinos.cn>

…-OS#21)

Copilot

Pull request overview

This PR adds Netlink Route support to enable Linux applications to retrieve network interface and address information through the Netlink protocol. The implementation references Asterinas and DragonOS designs and is essential for adapting FastDDS and ROS 2 to Starry.

Key changes:

Implements Netlink Route protocol with support for ip link show and ip addr show commands
Adds comprehensive message parsing and attribute handling infrastructure
Fixes filesystem open flag validation to conform to POSIX semantics

Reviewed changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
modules/axnet/src/socket.rs	Adds Netlink socket variant and address type to socket infrastructure
modules/axnet/src/service.rs	Exposes device iterator for Netlink route queries
modules/axnet/src/netlink/table.rs	Implements bind table for managing Netlink socket bindings and multicast groups
modules/axnet/src/netlink/route/mod.rs	Implements route transport layer with send/recv operations
modules/axnet/src/netlink/route/message/segment/*.rs	Defines route message segment structures for links and addresses
modules/axnet/src/netlink/route/message/attr/*.rs	Implements attribute parsing for link and address information
modules/axnet/src/netlink/route/handle.rs	Handles GetLink and GetAddr requests with device filtering
modules/axnet/src/netlink/receiver.rs	Implements message queue and receiver for async message handling
modules/axnet/src/netlink/mod.rs	Main Netlink socket implementation with bind/connect/send/recv operations
modules/axnet/src/netlink/message/*.rs	Core message parsing infrastructure with segments and attributes
modules/axnet/src/netlink/addr.rs	Netlink socket addressing with port and multicast group support
modules/axnet/src/lib.rs	Adds device index counter and Netlink module integration
modules/axnet/src/device/*.rs	Extends device trait with type, flags, index, and IP information
modules/axnet/Cargo.toml	Adds dependencies for Netlink feature
modules/axfs/src/highlevel/file.rs	Refactors file open options validation to fix POSIX compliance
api/axfeat/Cargo.toml	Adds netlink feature flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T17:47:44Z

modules/axnet/src/netlink/message/segment/mod.rs

+        align_up(payload_len, NLMSG_ALIGN) - payload_len
+    }
+
+    fn lecacy_padding_len() -> usize {


Corrected spelling of 'lecacy' to 'legacy'.

Suggested change

fn lecacy_padding_len() -> usize {

fn legacy_padding_len() -> usize {

Copilot · 2025-12-04T17:47:44Z

modules/axnet/src/netlink/route/message/segment/addr.rs

+        const DEPRECATED	 = 0x20;
+        const TENTATIVE		 = 0x40;
+        const PERMANENT		 = 0x80;
+        const MANAGETEMPADDR = 0x100;
+        const NOPREFIXROUTE	 = 0x200;
+        const MCAUTOJOIN	 = 0x400;
+        const STABLE_PRIVACY = 0x800;


Inconsistent whitespace in flag definitions; use consistent spacing between flag name and value.

Suggested change

const DEPRECATED = 0x20;

const TENTATIVE = 0x40;

const PERMANENT = 0x80;

const MANAGETEMPADDR = 0x100;

const NOPREFIXROUTE = 0x200;

const MCAUTOJOIN = 0x400;

const STABLE_PRIVACY = 0x800;

const DEPRECATED = 0x20;

const TENTATIVE = 0x40;

const PERMANENT = 0x80;

const MANAGETEMPADDR = 0x100;

const NOPREFIXROUTE = 0x200;

const MCAUTOJOIN = 0x400;

const STABLE_PRIVACY = 0x800;

Copilot · 2025-12-04T17:47:45Z

modules/axnet/src/netlink/route/handle.rs

+    },
+};
+
+/// An helper function to access the route protocol bind table.


Corrected grammar: 'An helper' should be 'A helper'.

Suggested change

/// An helper function to access the route protocol bind table.

/// A helper function to access the route protocol bind table.

Copilot · 2025-12-04T17:47:45Z

modules/axnet/src/device/loopback.rs

+        self.index
+    }
+
+    fn ipv4_addr(&self) -> Option<Ipv4Addr> {


Return type uses Ipv4Addr from std::net, but Device trait definition shows Option<Ipv4Address> from smoltcp. The trait definition should use the stdlib type for consistency, or this implementation should match the trait's smoltcp type.

Copilot · 2025-12-04T17:47:45Z

modules/axnet/src/device/ethernet.rs

+        self.index
+    }
+
+    fn ipv4_addr(&self) -> Option<Ipv4Address> {


Return type uses Ipv4Address from smoltcp, which is inconsistent with loopback device's use of Ipv4Addr from std::net. Both implementations should use the same type for consistency.

Copilot · 2025-12-04T17:47:45Z

modules/axnet/src/netlink/message/segment/header.rs

+    /// Reference: <https://elixir.bootlin.com/linux/v6.13/source/include/uapi/linux/netlink.h#L86>.
+    pub struct AckFlags: u16 {
+        const CAPPED = 0x100;
+        const ACK_TLVS = 0x100;


Two different flags have the same value 0x100. This appears to be a copy-paste error - these flags should have distinct values.

Suggested change

const ACK_TLVS = 0x100;

const ACK_TLVS = 0x200;

AsakuraMizu and others added 11 commits December 3, 2025 20:43

fix(task): add clear_interrupt

f43a18b

fix(display): framebuffer_flush no panic

9073022

chore(display): graphics -> display

8dd9a8d

chore: add uspace feature

e0bec12

wip

809762f

feat(net): vsock

679e595

Co-authored-by: 朝倉水希 <asakuramizu111@gmail.com>

fix(mm): flush tlb after memory init (Starry-OS#13)

58c783b

Signed-off-by: Weikang Guo <guoweikang@kylinos.cn> Co-authored-by: Weikang Guo <guoweikang@kylinos.cn> Co-authored-by: zhangguoyu <zhangguoyu@kylinos.cn>

fix(mm): handle concurrent page faults on same page (Starry-OS#16)

81a81bb

fix(mm): add align parameter to AddrSpace::find_free_area (Starry…

de4c455

…-OS#21)

fix(fs): fix open option validation

37a65d1

feat(net): add netlink route

6fa9b30

Copilot AI review requested due to automatic review settings December 4, 2025 17:46

Copilot AI reviewed Dec 4, 2025

View reviewed changes

This was referenced Dec 4, 2025

feat: add netlink route support and misc fixes Starry-OS/StarryOS#71

Draft

feat: add BufWriter and extend buffered I/O traits and impls Starry-OS/axio#1

Closed

AsakuraMizu force-pushed the dev branch from de4c455 to 9253879 Compare December 8, 2025 09:19

AsakuraMizu force-pushed the dev branch from 8195846 to 9a39bb7 Compare December 16, 2025 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(net): add netlink route support #25

feat(net): add netlink route support #25

Uh oh!

Anekoique commented Dec 4, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	fn lecacy_padding_len() -> usize {
	fn legacy_padding_len() -> usize {

	/// An helper function to access the route protocol bind table.
	/// A helper function to access the route protocol bind table.

feat(net): add netlink route support #25

Are you sure you want to change the base?

feat(net): add netlink route support #25

Uh oh!

Conversation

Anekoique commented Dec 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants