fix(smp): move accessing_user_memory into thread data
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nough. Closes: #102 Signed-off-by: Weikang Guo <guoweikang@kylinos.cn>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in SMP (symmetric multiprocessing) scenarios where concurrent access to user memory could cause undefined behavior. The fix changes the ACCESSING_USER_MEM flag from an AtomicBool to an AtomicUsize, implementing reference counting to properly track multiple concurrent accesses.
Key Changes:
- Replaced boolean flag with atomic counter to support concurrent user memory access tracking
- Updated access tracking to use
fetch_add/fetch_subfor increment/decrement operations - Modified the check to compare counter against zero instead of a boolean value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Weikang Guo <guoweikang@kylinos.cn>
guoweikang
force-pushed
the
gwk/bug_fix_ub_badaddress
branch
from
0b8b82e to
a4adcb6
Compare
Signed-off-by: Weikang Guo <guoweikang@kylinos.cn>
guoweikang
force-pushed
the
gwk/bug_fix_ub_badaddress
branch
from
a4adcb6 to
51f8467
Compare
AsakuraMizu
changed the title
accessing_user_memory into thread data
AsakuraMizu
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #94
Closes: #102