delete pointless requirements parsing code in dist_utils.py#71
Merged
cognifloyd merged 2 commits intomasterfrom Mar 15, 2023
Merged
delete pointless requirements parsing code in dist_utils.py#71cognifloyd merged 2 commits intomasterfrom
cognifloyd merged 2 commits intomasterfrom
Conversation
Please people. Do not do things on import! Plus, all the magic around parsing requirements was entirely unnecessary for this repo as there are NO reqs.
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
cognifloyd
changed the title
rush-skills
approved these changes
Mar 15, 2023
Member
rush-skills
left a comment
rush-skills
left a comment
There was a problem hiding this comment.
Those bits do seem very wrong in our setup files. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the magic around parsing requirements was entirely unnecessary for this repo as there are NO reqs.
And please! Doing things on import (like raising an error if pip isn't installed) is not ok.
Do not have side effects on import, even (and especially) in setup code.
This fix is a follow-up for #70, and is blocking StackStorm/st2#5932 because importing pip breaks generating the lockfile in the latest version of pants (which uses pex, which has a vendored copy of pip).