( #275 ) Allow context Use in WorkflowRehearsal#276
Open
jpavlav wants to merge 2 commits intoStackStorm:masterfrom
Open
( #275 ) Allow context Use in WorkflowRehearsal#276jpavlav wants to merge 2 commits intoStackStorm:masterfrom
context Use in WorkflowRehearsal#276jpavlav wants to merge 2 commits intoStackStorm:masterfrom
Conversation
40d4466 to
60f3d83
Compare
This addresses the issue outlined in StackStorm#275. The shape of the context I created for the unit tests is `st2` similar to the runtime context provided by the `st2` `orquesta` runner.
60f3d83 to
c3abc14
Compare
Author
|
@guzzijones hey there! Could you take a look at this one? We are really loving using workflow unit tests. It's made things exponentially better for us. |
Author
|
👋 Just wanted to pop in on this and see if I need to do anything else. Review would be much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue outlined in #275. The shape of the context I created for the unit tests is
st2similar to the runtime context provided by thest2orquestarunner. This makes it easier to testStackStormworkflows that rely on context to function. For things like thest2kv_function and thetaskfunction, those can be easily enough added by a user by extendingorquesta.expressions.functions. Having said that, I thought it might be a bit too tightly coupled to add fixture functions in for that functionality.Beyond the tests I added to this repo, here is a token example of how this can be used by folks wanting to write unit tests for their workflows:
Minimal Workflow - includes
ctxreferenceTesting the workflow with context
Outcome