Skip to content

Conversation

@jeda
Copy link
Contributor

@jeda jeda commented Dec 21, 2025

This Pull Requests adds support for the SVCB and HTTPS records to the BUNNY_DNS provider.

  • I'm not 100% sure how to make the code look better when it comes to handling the merging/separating Target/Params from the Value record (Bunny.net uses a single Value). Happy to hear any feedback about this.
  • Tests work... except for 17:HTTPS:Change_HTTPS_params-empty and 19:SVCB:Change_SVCB_params-empty - but this is a requirement from Bunny.net's side. Not sure if there's anything that needs to be added to dnscontrol to handle this scenario. (This would be something for auditrecords.go, but there's no module for SVCB/HTTPS that I can see)

@tlimoncelli
Copy link
Collaborator

Hello friend!

The merging/separating Tager/Params looks fine by me!

As far as tests 17 and 19. You can add functions for HttpsHasNullTarget / ScvbHasNullTarget yourself. I'd recommend putting them in pkg/rejectif/httpsscvb.go (a new file). The testing framework should automatically skip the "Change HTTPS params-empty" step. Look at other rejectif/*.go files for examples.

@tlimoncelli
Copy link
Collaborator

Friendly ping?

@jeda
Copy link
Contributor Author

jeda commented Jan 11, 2026

Apologies for the delay, got a tad busy. Will get back to this later today :)

@jeda jeda force-pushed the bunnydns-add-svcb-and-https branch from ebd94ee to 623e33b Compare January 16, 2026 01:33
@jeda
Copy link
Contributor Author

jeda commented Jan 16, 2026

Looks like after some discussion with support, they've eased their record parser, and now the tests pass. No need to do further adjustments to dnscontrol, so this should be good to go.

I've rebased the commit based on the latest main.

@tlimoncelli
Copy link
Collaborator

Fantastic! Thanks for reaching out to the provider to get this resolved!

@tlimoncelli tlimoncelli merged commit bd40291 into StackExchange:main Jan 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants