Skip to content

Conversation

@dancormier
Copy link
Contributor

@dancormier dancormier commented Jan 13, 2026

SPARK-154


This PR updates our set of "sizing units" to the new batch detailed in SPARK-154. I also took this opportunity to clean up our sizing/spacing in general to make it easier to maintain.

Notable changes

Visual

Docs

  • Split width-height.html into width.html and height.html
    • I felt the single page was too difficult to traverse and too noisy.

Under the hood

  • Consolidated two #build-classes Less functions into a single one
  • Split width-height.less into width.less and height.less

Custom properties

  • Replaced property calcs of negative values
    • For example, calc(var(--su1) * -1)) becomes var(--sun1)
    • These changes represent the majority or .less files changed
  • Replaced any references to --s-full and --s-step with their sizing unit counterparts
    • For example, calc(var(--s-step) * 10) becomes --su1024

Tests

  • Updated Less snapshot tests for "spacing" (aka margin and padding)
  • Added Less snapshot tests for height, positioning, sizing, and width

How to test

TODO

  • Complete docs
  • Add less tests
  • Add changeset
  • Complete Migration Guide updates

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026

🦋 Changeset detected

Latest commit: 1278bf9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 1278bf9
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6966afc3cde9a900085300e2
😎 Deploy Preview https://deploy-preview-2122--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 1278bf9
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6966afc3484c9000080fd077
😎 Deploy Preview https://deploy-preview-2122--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants