Skip to content

Conversation

@Meir017
Copy link
Contributor

@Meir017 Meir017 commented Jul 23, 2025

Extends continuous integration coverage by adding a dedicated macOS job that mirrors the existing Windows and Linux test environments.

Installs Redis via Homebrew and configures multiple .NET versions (6.0, 8.0, 9.0) to ensure cross-platform compatibility and comprehensive test coverage across different operating systems.

image

Extends continuous integration coverage by adding a dedicated macOS job that mirrors the existing Windows and Linux test environments.

Installs Redis via Homebrew and configures multiple .NET versions (6.0, 8.0, 9.0) to ensure cross-platform compatibility and comprehensive test coverage across different operating systems.
@Meir017 Meir017 closed this Jul 23, 2025
Switches from installing Redis via Homebrew to using docker compose for better consistency and isolation in CI environment.

Removes manual Redis service management and verification steps in favor of docker compose's built-in wait functionality.
@Meir017 Meir017 reopened this Jul 23, 2025
@mgravell
Copy link
Collaborator

I'm in two minds about this; it seems like the most likely outcome here is simply: slower builds - I can't really recall any scenarios where we've had macos specific problems, and in reality macos is very much the minority anticipated execution environment. I'm all for it working, but I'm not sure we need to run it for every PR/commit.

What's your thoughts, @NickCraver, as someone with more of a CI overview?

@mgravell
Copy link
Collaborator

As a secondary observation:

Run docker compose -f docker-compose.yml up -d --wait
/Users/runner/work/_temp/739e6771-49b7-4f5d-b7df-37bbbd88d8b2.sh: line 1: docker: command not found
Error: Process completed with exit code 127.

@Meir017
Copy link
Contributor Author

Meir017 commented Jul 24, 2025

As a secondary observation:

Run docker compose -f docker-compose.yml up -d --wait
/Users/runner/work/_temp/739e6771-49b7-4f5d-b7df-37bbbd88d8b2.sh: line 1: docker: command not found
Error: Process completed with exit code 127.

I thought it would be simple, but looks like docker is not supported yet https://stackoverflow.com/questions/77675906/github-actions-build-docker-image-on-arm64-macos-latest-xlarge

it seems like the most likely outcome here is simply: slower builds
I'm not sure about this one, as the pipelines will run concurrently, and the Windows build is relatively slow

@mgravell
Copy link
Collaborator

I thought it would be simple, but looks like docker is not supported yet

So should we shelve this for the foreseeable?

@NickCraver
Copy link
Collaborator

We shouldn't add this - it doesn't add value but does eat build minutes we have limited capacity of :)

@Meir017 Meir017 closed this Jul 25, 2025
@Meir017 Meir017 deleted the chore/run-ci-on-macos branch July 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants