fix (README): Properly recognize Fernando's Good Boy status#29
Open
n0kovo wants to merge 2 commits intoStability-AI:masterfrom
Open
fix (README): Properly recognize Fernando's Good Boy status#29n0kovo wants to merge 2 commits intoStability-AI:masterfrom
n0kovo wants to merge 2 commits intoStability-AI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was examining the
README.md, particularly the section about LoRA training, I stumbled upon a segment that, while informative, seems to have overlooked a critical detail that I believe warrants correction.Current Text:
For example, training a LoRA on my dog with the following kind of training images[...]Lets me generate the following images of my dog given the promptAn integral component of this example seems to have been inadvertently omitted, leading to a potential miscommunication of the narrative and the role of the involved parties.
Suggested Revision:
For example, training a LoRA on my dog Fernando (a very good boy) with the following kind of training images[...]Lets me generate the following images of Fernando given the promptWhy This Correction is Imperative:
Upholding Character Integrity: Ignoring Fernando's right to be recognized as a very good boy not only detracts from the quality of the documentation, but also does a disservice to Fernando himself. His character plays a pivotal role in the narrative, and omitting such a fundamental aspect undermines the integrity of his portrayal.
Enhancing Reader Engagement: Acknowledging Fernando's status as a very good boy adds an element of personality to the documentation. It transforms a standard technical example into a more engaging and memorable narrative, fostering a stronger connection with the audience. This inclusion makes the technical content more relatable and enjoyable, enhancing the overall reader experience.
Warmest regards,
n0kovo