Fix null cause for resistance modifier during damage#4277
Fix null cause for resistance modifier during damage#4277MC-Nirvana wants to merge 2 commits intoSpongePowered:api-12from
Conversation
Signed-off-by: 涅槃 <mcnirvana@126.com>
gabizou
left a comment
gabizou
left a comment
There was a problem hiding this comment.
What is the submodule update? Is it needed for the bug fix?
Hmm... The submodule update has nothing to do with this bug; it just allows you to skip the tests that Gradle runs by default during the build. |
|
Please provide a description of what you are trying to fix. In this case, linking the issue should be enough. I know this issue has been discussed on Discord but someone that doesn't not follow every message on our Discord will not know what you are talking about. Also we sometimes look at issues months later, anything on Discord would basically be lost. |
|
| } | ||
|
|
||
| private static DamageModifier buildDamageReductionModifier(final DefaultedRegistryReference<DamageModifierType> modifierType, Object... causes) { | ||
| // 过滤掉 null 值并确保至少有一个元素 |
There was a problem hiding this comment.
Please use English everywhere, including in the comments. These comments aren't needed anyway as they just paraphrase the code, you can delete them.
build.gradle.kts
Outdated
|
|
||
| gradle.beforeProject { | ||
| tasks.withType<Test>().configureEach { | ||
| enabled = false |
There was a problem hiding this comment.
Please don't disable the tests. They ensure that the changes do not introduce a regression.
|
I want to know what exactly you mean—are you not planning to fix this bug, or will you resolve it on your own in the near future? |
Signed-off-by: 涅槃 <mcnirvana@126.com>
|
The code has been updated. Please check it. |
|
I'll resubmit a PR. I seem to have messed up my local and remote repositories. |
Yeregorix
changed the title
3 participants
Fix #4276