Skip to content

Conversation

@RichardHightower
Copy link
Contributor

Summary

  • Fix 21 failing Playwright E2E tests by adding data-testid attributes to React components
  • Fix Tauri build by excluding rulez_ui/src-tauri from Cargo workspace
  • Add task run-app command to launch the RuleZ UI desktop app

Changes

E2E Test Fixes

  • Added data-testid attributes to EventForm, FileTabBar, EditorToolbar, and Sidebar components
  • Updated test selectors to use data-testid instead of fragile CSS class/text matching
  • Fixed strict mode violations where selectors matched multiple elements
  • All 56 E2E tests now pass on both Chromium and WebKit

Tauri Build Fix

  • Added rulez_ui/src-tauri to workspace.exclude in root Cargo.toml
  • Added src-tauri/gen to .gitignore for generated Tauri files

New Command

  • Added task run-app at project root to launch RuleZ UI desktop app

Test plan

  • All 56 E2E tests pass (task ui:e2e)
  • Tauri dev server starts (task run-app)
  • Lint and typecheck pass

🤖 Generated with Claude Code

RichardHightower and others added 5 commits January 29, 2026 15:11
…electors

Add data-testid attributes to React components for reliable test selectors:
- EventForm: event-type-select, tool-input, command-input, path-input, simulate-button
- FileTabBar: file-tab-bar, file-tab-{filename}, close-tab-{filename}
- EditorToolbar: editor-toolbar
- Sidebar: sidebar, sidebar-{section}-file-{filename}

Update test files to use data-testid selectors instead of fragile CSS class
and text matching that caused strict mode violations.

Update page objects with new selector patterns for better test maintainability.

All 56 E2E tests now pass on both Chromium and WebKit.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The Tauri project was incorrectly detected as part of the CCH workspace,
causing cargo metadata errors when running tauri build/dev commands.

Adding rulez_ui/src-tauri to workspace.exclude allows the Tauri app
to build independently while keeping the CCH CLI in the main workspace.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ignore Tauri-generated files that are created during builds.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a convenient `task run-app` command at the project root to start
the RuleZ UI Tauri desktop application with a single command.

Usage: task run-app

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Prevents "Port 1420 is already in use" errors when restarting the app.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants