Move generate_ground_truth_recording to generation module#4588
Open
h-mayorquin wants to merge 1 commit into
Open
Move generate_ground_truth_recording to generation module#4588h-mayorquin wants to merge 1 commit into
generate_ground_truth_recording to generation module#4588h-mayorquin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was left out by mistake from #4520.
generate_ground_truth_recordingshould also be in the generation module to avoid a dependency of core into generation.I also dropped
strategy=from test fixtures and the two production callsites that pass it explicitly, keeping the kwarg itself defined on theNoiseGeneratorRecordingandMockRecordingclasses (whose removal is under discussion in #4522). This overlaps with the callsite cleanup in @cwindolf's #4586 (temporally-correlated noise V2, which follows on from #4587) and should make that PR cleaner. Both branches edit the same lines, so the merge should resolve cleanly regardless of order.