Skip to content

Fixed error in eWiseMultInverted #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vano105 wants to merge 3 commits into
base: master
Choose a base branch
from
+62 −2
Open

Fixed error in eWiseMultInverted #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdde07e
Fix error in eWiseMultInverted
vano105 Mar 29, 2026
4e3ab7f
Add tests for empty matrix in eWiseMultInverted
vano105 Mar 29, 2026
37ccfd8
Fixed error in clang-format
vano105 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cubool/sources/cuda/cuda_matrix_ewisemult_inverted.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace cubool {
assert(b->getNrows() == M);
assert(b->getNcols() == N);

if (a->isMatrixEmpty() || b->isMatrixEmpty()) {
if (a->isMatrixEmpty()) {
this->clearAndResizeStorageToDim();
return;
}
Expand Down
59 changes: 59 additions & 0 deletions cubool/tests/test_matrix_ewisemult_inverted.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,64 @@ TEST(cuBool_Matrix, ApplyMatrixRandom) {
ASSERT_EQ(cuBool_Finalize(), CUBOOL_STATUS_SUCCESS);
}

TEST(cuBool_Matrix, ApplyMatrixEmptyMask) {
ASSERT_EQ(cuBool_Initialize(CUBOOL_HINT_NO), CUBOOL_STATUS_SUCCESS);

DataMatrix matrix{
{1, 0, 1},
{0, 1, 0},
{1, 1, 0},
};

DataMatrix mask{
{0, 0, 0},
{0, 0, 0},
{0, 0, 0},
};

testApplyNotMask(matrix, mask);

ASSERT_EQ(cuBool_Finalize(), CUBOOL_STATUS_SUCCESS);
}

TEST(cuBool_Matrix, ApplyMatrixEmptySource) {
ASSERT_EQ(cuBool_Initialize(CUBOOL_HINT_NO), CUBOOL_STATUS_SUCCESS);

DataMatrix matrix{
{0, 0, 0},
{0, 0, 0},
{0, 0, 0},
};

DataMatrix mask{
{1, 0, 1},
{0, 1, 0},
{1, 1, 0},
};

testApplyNotMask(matrix, mask);

ASSERT_EQ(cuBool_Finalize(), CUBOOL_STATUS_SUCCESS);
}

TEST(cuBool_Matrix, ApplyMatrixBothEmpty) {
ASSERT_EQ(cuBool_Initialize(CUBOOL_HINT_NO), CUBOOL_STATUS_SUCCESS);

DataMatrix matrix{
{0, 0, 0},
{0, 0, 0},
{0, 0, 0},
};

DataMatrix mask{
{0, 0, 0},
{0, 0, 0},
{0, 0, 0},
};

testApplyNotMask(matrix, mask);

ASSERT_EQ(cuBool_Finalize(), CUBOOL_STATUS_SUCCESS);
}

CUBOOL_GTEST_MAIN
3 changes: 2 additions & 1 deletion scripts/run_tests_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@
./cubool/tests/test_vector_ewisemult
./cubool/tests/test_vector_mxv
./cubool/tests/test_vector_vxm
./cubool/tests/test_vector_sub_vector
./cubool/tests/test_vector_sub_vector
./cubool/tests/test_matrix_ewisemult_inverted
Loading