fix: filter out comment node to prevent sorting issue with collapsibl…#1223
Open
Belinda-advmeds wants to merge 1 commit intoSortableJS:masterfrom
Open
fix: filter out comment node to prevent sorting issue with collapsibl…#1223Belinda-advmeds wants to merge 1 commit intoSortableJS:masterfrom
Belinda-advmeds wants to merge 1 commit intoSortableJS:masterfrom
Conversation
hexiaokang
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a table has collapsible items, or the table row has dynamic items depending on vue directive v-if/v-show,
the dragging behavior is wired and the sorting order is wrong.
Root Cause
In addition to the actual rows, the rows with v-if directive false will be comment nodes which causes the dragging target is wrong.
Solution
Filter out comment nodes to avoid the bug