Issue 1213: Fix accessing nextSibling property in insertNodeAt function#1214
Open
szczupag wants to merge 1 commit intoSortableJS:masterfrom
Open
Issue 1213: Fix accessing nextSibling property in insertNodeAt function#1214szczupag wants to merge 1 commit intoSortableJS:masterfrom
szczupag wants to merge 1 commit intoSortableJS:masterfrom
Conversation
Author
|
Hi @David-Desmaisons is there any chance for getting this fix reviewed and merged? |
|
@David-Desmaisons I would like to work with this library and support the project, but I would like to know if you will review the PRs. It's good for the sanity of your project to at least reply to the PR if you are going (or not) to merge. I understand if you are busy, so it is a good idea to talk with another maintainer to help do a code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1213 (problem and solution are already explained there)