Skip to content

fix(Expo): SDK55 Android build failure in MainApplication patch#116

Merged
floydkim merged 1 commit intomasterfrom
fix-expo-android-comma
Feb 18, 2026
Merged

fix(Expo): SDK55 Android build failure in MainApplication patch#116
floydkim merged 1 commit intomasterfrom
fix-expo-android-comma

Conversation

@floydkim
Copy link
Collaborator

Background

Android builds for Expo SDK55 could fail because the generated MainApplication.kt sometimes had invalid comma placement after plugin patching.

Root cause

The Expo plugin logic that injects jsBundleFilePath did not consistently normalize trailing commas around the packageList argument block, which could produce invalid Kotlin syntax for certain template shapes.

Changes

  • Expanded the packageList matching pattern to handle cases with/without an existing jsBundleFilePath line.
  • Normalized trailing comma handling before injecting jsBundleFilePath.
  • Added test assertion to verify comma normalization and prevent regressions.

@floydkim floydkim merged commit 694a401 into master Feb 18, 2026
2 checks passed
@floydkim floydkim deleted the fix-expo-android-comma branch February 18, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments