fix(Expo): fix app stuck on splash screen in SDK 54#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #97
I updated the Expo config plugin so that the workaround mentioned in the issue comment is now applied only to Expo 54.
At first, I considered adding a getter method that would ensure an instance is created when accessed.
However, that approach could introduce a breaking change for RN CLI users, making it unsuitable for quick adoption.
It's also unclear whether the same issue will occur in Expo SDK 55.
If it doesn’t, I hope the setup will continue to use the original code.
(For Expo users, differences in native code might not be a major concern, though.)