hotfix: sanitize public form submission data to prevent stored XSS#700
Merged
hotfix: sanitize public form submission data to prevent stored XSS#700
Conversation
Form submissions from unauthenticated users were stored with raw string values, allowing script injection payloads to execute when admins view submissions. Add recursive sanitizeDeep() that HTML-encodes all string values in the arbitrary submission JSON before storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from #671 by @mmcintosh
Security hotfix: prevents stored XSS via unauthenticated public form submissions. The public form submission endpoint stored arbitrary JSON from anonymous users without sanitization, allowing
<script>tags to execute with admin session cookies when viewing submissions.Changes
sanitizeDeep()— recursively HTML-encodes all string values in arbitrary nested JSON before storageAttribution
Changes by Maintainer
Closes #671
🤖 Generated with Claude Code