fix: restrict public content API access by status and role#693
Closed
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
Closed
fix: restrict public content API access by status and role#693bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restricts the public content listing API so unpublished content is no longer exposed by default. Anonymous requests are now published-only, and non-public status access on the public list endpoints is limited to
adminandeditorroles.Fixes #692
Changes
GET /api/contentGET /api/collections/:collection/contentadmin/editormay request non-published statusesauthor/viewerremain published-only on these public list endpointsoptionalAuth()to the public content list routes and normalize status filters safelyTesting
npm test --workspace=packages/core -- api-content-access-policy.test.ts api-public-content-status.test.tsnpm run type-checkBASE_URL=http://localhost:8787 npx playwright test tests/e2e/62-public-content-api-status-visibility.spec.ts --config tests/playwright.config.tsUnit Tests
E2E Tests
Screenshots/Videos
Checklist