Skip to content

SONARJAVA-6456 Remove deprecated rules S4792, S6291 and S6300#5664

Open
pierre-loup-tristant-sonarsource wants to merge 1 commit into
masterfrom
plt/sonarjava-6456
Open

SONARJAVA-6456 Remove deprecated rules S4792, S6291 and S6300#5664
pierre-loup-tristant-sonarsource wants to merge 1 commit into
masterfrom
plt/sonarjava-6456

Conversation

@pierre-loup-tristant-sonarsource

Copy link
Copy Markdown
Contributor

$(cat <<'EOF'

Summary

  • Remove implementation of deprecated rule S4792 (LogConfigurationCheck, deprecated since 7.30)
  • Remove implementation of deprecated rule S6291 (AndroidUnencryptedDatabaseCheck, deprecated since 8.15)
  • Remove implementation of deprecated rule S6300 (AndroidUnencryptedFilesCheck, deprecated since 8.15)
  • Remove corresponding test files, test sample files, and rule metadata JSON files
  • Remove S4792 entry from autoscan-diff-by-rules.json

Test plan

  • check-list unit tests: 15/15 pass
  • java-checks unit tests: no new failures vs master
  • its/ruling integration tests: identical results to master (3 pre-existing failures unrelated to this change)
    EOF
    )

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6456

@gitar-bot

gitar-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown
CI failed: The build failed because integration tests and quality profiles still reference the deprecated and removed rules S4792, S6291, and S6300, causing test failures and configuration mismatches.

Overview

Multiple integration tests failed across different environments because the PR removed rules S4792, S6291, and S6300 without updating the corresponding test baselines and configuration profiles that explicitly require these rules to be active.

Failures

Integration Test Baseline Mismatch (confidence: high)

  • Type: test
  • Affected jobs: Autoscan Tests
  • Related to change: yes
  • Root cause: The Autoscan integration tests compare output against baseline files that still expect the presence of the removed rules. The generated output no longer contains them, causing a diff failure.
  • Suggested fix: Update the baseline files in its/autoscan/src/test/resources/autoscan/ to match the current rule set. Copy results from target/actual/autoscan-diffs to the resource directory.

Inactive Rule Configuration Error (confidence: high)

  • Type: build
  • Affected jobs: Ruling QA
  • Related to change: yes
  • Root cause: The sonar-maven-plugin execution is failing because the quality profile or analysis configuration used in the integration tests still includes rule java:S4792 as an active rule, which no longer exists in the project.
  • Suggested fix: Search the its/ directory for any quality profile files or configuration manifests that reference java:S4792 (or the other removed rules) and remove those entries.

Summary

  • Change-related failures: 2. All failures are direct consequences of removing rules without updating legacy integration test expectations and profile configurations.
  • Infrastructure/flaky failures: 0. (Note: minor network timeouts were observed in some jobs, but these were secondary to the primary configuration/test failures.)
  • Recommended action: Update all integration test baselines and static quality profile configurations in the its/ directory to remove references to the deprecated rules.
Code Review ✅ Approved

Removes deprecated rules S4792, S6291, and S6300 along with their associated test suites and metadata files. No issues found.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

sonarqube-next Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant