SONARJAVA-5975 S6856: Add support for record component extraction#5520
Merged
asya-vorobeva merged 1 commit intomasterfrom Mar 11, 2026
Merged
SONARJAVA-5975 S6856: Add support for record component extraction#5520asya-vorobeva merged 1 commit intomasterfrom
asya-vorobeva merged 1 commit intomasterfrom
Conversation
Contributor
asya-vorobeva
force-pushed
the
asya/S6856-improve-1
branch
3 times, most recently
from
4d1505f to
ce6f433
Compare
aurelien-coet-sonarsource
approved these changes
Mar 10, 2026
Contributor
aurelien-coet-sonarsource
left a comment
aurelien-coet-sonarsource
left a comment
There was a problem hiding this comment.
Just two small comments, but otherwise LGTM
| type.symbol().memberSymbols().stream() | ||
| .filter(Symbol::isVariableSymbol) | ||
| .map(Symbol.VariableSymbol.class::cast) | ||
| .filter(f -> !f.isStatic()).forEach(field -> properties.add(getComponentName(field))); |
Contributor
There was a problem hiding this comment.
Nitpick: for readability
Suggested change
| .filter(f -> !f.isStatic()).forEach(field -> properties.add(getComponentName(field))); | |
| .filter(f -> !f.isStatic()) | |
| .forEach(field -> properties.add(getComponentName(field))); |
|
|
||
| static class RecordBinding { | ||
| @GetMapping("/reports/{project}/{year}/{month}") // Noncompliant | ||
| // Compliant |
Contributor
There was a problem hiding this comment.
Should this // Compliant comment be removed ?
- Support @BindParam annotation for custom binding names on record components - Records are only processed for Spring Web >= 5.3 - Update rule description and title Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
asya-vorobeva
force-pushed
the
asya/S6856-improve-1
branch
from
ce6f433 to
84c43bd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SONARJAVA-5975