SONARJAVA-6003 Fix FP on S2055 when a superclass has a compliant Lombok generated co…#5518
Merged
aurelien-coet-sonarsource merged 2 commits intomasterfrom Mar 10, 2026
Merged
Conversation
Contributor
| if (value instanceof Symbol symbol) { | ||
| return symbol.name(); | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
Honestly, for access attribute value always will be Symbol (because it's always an AccessLevel enum value). So we can simply do smth like "PRIVATE".equals(((Symbol)v.value()).name())
asya-vorobeva
approved these changes
Mar 9, 2026
Contributor
asya-vorobeva
left a comment
asya-vorobeva
left a comment
There was a problem hiding this comment.
LGTM (see optional comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.