SONARJAVA-6122 Change the implementation of S3078 to cover more operations#5509
Merged
aurelien-coet-sonarsource merged 5 commits intomasterfrom Mar 5, 2026
Merged
SONARJAVA-6122 Change the implementation of S3078 to cover more operations#5509aurelien-coet-sonarsource merged 5 commits intomasterfrom
aurelien-coet-sonarsource merged 5 commits intomasterfrom
Conversation
Contributor
tomasz-tylenda-sonarsource
requested changes
Mar 4, 2026
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
Looks like this PR does not build. Could you please fix it?
aurelien-coet-sonarsource
force-pushed
the
ac/SONARJAVA-6122
branch
from
15e89ff to
6ece6c7
Compare
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
Maybe we should discuss this offline?
java-checks-test-sources/default/src/main/java/checks/VolatileVariablesOperationsCheck.java
Outdated
Show resolved
Hide resolved
java-checks/src/main/java/org/sonar/java/checks/VolatileVariablesOperationsCheck.java
Show resolved
Hide resolved
|
tomasz-tylenda-sonarsource
approved these changes
Mar 5, 2026
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
I'm wondering if we should update RSpec. If you want to do this, then please finish Rspec and add it here before merging.
I'm totally fine not doing it though, because volatile fields are a rarely used feature and this ticket is something we found internally, without any user feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.