Skip to content

SONARJAVA-6180 Fix FP on S5853 when "element" is called after "assertThat" #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aurelien-coet-sonarsource merged 2 commits into from
Mar 3, 2026
Merged

SONARJAVA-6180 Fix FP on S5853 when "element" is called after "assertThat" #5502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc332ea
Fix FP on S5853 when "element" is called after "assertThat"
aurelien-coet-sonarsource Mar 2, 2026
8088e36
Apply suggestion from @rombirli
aurelien-coet-sonarsource Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...st-sources/default/src/test/java/checks/tests/AssertJConsecutiveAssertionCheckSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ void assert_on_member_select_2() {
assertThat(myList.get(1)).isEqualTo("42");
}

@Test
void assert_on_element() {
assertThat(myList).isNotNull().hasSize(2).element(0).isEqualTo("42"); // Compliant, assertions following the call to 'element' apply on a specific element
assertThat(myList).element(1).isEqualTo("10");
}

@Test
void assert_on_member_select_3() {
Expand Down
2 changes: 1 addition & 1 deletion java-checks/src/main/java/org/sonar/java/checks/tests/AssertJConsecutiveAssertionCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class AssertJConsecutiveAssertionCheck extends IssuableSubscriptionVisito
public static final MethodMatchers ASSERTJ_SET_CONTEXT_METHODS = MethodMatchers.create()
.ofSubTypes("org.assertj.core.api.AbstractAssert")
.name(name -> name.startsWith("extracting") || name.startsWith("using") || name.startsWith("filtered")
|| "flatExtracting".equals(name) || "map".equals(name) || "flatMap".equals(name))
|| "flatExtracting".equals(name) || "map".equals(name) || "flatMap".equals(name) || "element".equals(name))
.withAnyParameters()
.build();

Expand Down
Loading