SONARJAVA-6082 S8471 Minimize the number of bound ScopedValues for performance

[aurelien-coet-sonarsource]

No description provided.

[hashicorp-vault-sonar-prod]

SONARJAVA-6082

[rombirli]

Should we also check the case carrier are assigned to variables? for example

var c1 = ScopedValue.where(...)
var c2 = c1.where(...)
...

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[rombirli]

We still aren't detecting cases like the one below. As Asya suggested, there may be a more robust way to handle this, specifically by identifying which Scoped Values are consistently bound together. Let's hold off on including this in the current release and refine the proposal for a later update.

void main() {
  ScopedValue.Carrier c1 = ScopedValue.where(ScopedValue.newInstance(), "John");
  ScopedValue.Carrier c2 = c1.where(ScopedValue.newInstance(), "John");
  ScopedValue.Carrier c3 = c2.where(ScopedValue.newInstance(), "John"); // Noncompliant
  ScopedValue.Carrier c4 = c3.where(ScopedValue.newInstance(), "John"); // Noncompliant
}