Skip to content

BUILD-8956 Verify config-poetry action#110

Draft
hedinasr wants to merge 3 commits into
masterfrom
feat/hnasr/BUILD-8956-verifyConfigPoetry
Draft

BUILD-8956 Verify config-poetry action#110
hedinasr wants to merge 3 commits into
masterfrom
feat/hnasr/BUILD-8956-verifyConfigPoetry

Conversation

@hedinasr

Copy link
Copy Markdown
Contributor

Summary

Dogfood PR to validate the new config-poetry action from SonarSource/ci-github-actions#292.

  • Adds a Verify config-poetry job that runs the standalone action, then poetry install and poetry build
  • Points build-poetry at feat/hnasr/BUILD-8956-createConfigPoetry for end-to-end validation through the refactored build action

Test plan

  • Verify config-poetry job passes (standalone action + Poetry install/build via Repox)
  • Build job passes (build-poetry consuming config-poetry internally)
  • Promote job passes

Revert action refs to @master / @v1 after ci-github-actions#292 is merged.

Add a verify-config-poetry job that exercises the standalone action,
and point build-poetry at the feature branch for end-to-end validation.
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 11, 2026

Copy link
Copy Markdown

BUILD-8956

Replace the separate verify job with an inline config-poetry step
ahead of build-poetry in the existing build workflow.
Promote was incrementing the build number in a separate job because
get-build-number could not restore the cache from config-poetry.
@hedinasr hedinasr deployed to sca-checking June 11, 2026 14:38 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

@hedinasr hedinasr marked this pull request as ready for review June 12, 2026 12:48
@hedinasr hedinasr requested a review from a team as a code owner June 12, 2026 12:48
Copilot AI review requested due to automatic review settings June 12, 2026 12:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow to dogfood and validate the new config-poetry GitHub Action and to pass the produced build number into the promote job.

Changes:

  • Exposes BUILD_NUMBER as an output from the build job (sourced from the config-poetry step).
  • Adds mise-action setup and runs the standalone config-poetry action before build-poetry.
  • Propagates BUILD_NUMBER into the promote job environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
outputs:
BUILD_NUMBER: ${{ steps.config-poetry.outputs.BUILD_NUMBER }}
Comment on lines +33 to +34
uses: SonarSource/ci-github-actions/config-poetry@feat/hnasr/BUILD-8956-createConfigPoetry # dogfood
- uses: SonarSource/ci-github-actions/build-poetry@feat/hnasr/BUILD-8956-createConfigPoetry # dogfood
@gitar-bot

gitar-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Integrates the new config-poetry action into the build pipeline and propagates the build number to the promotion job. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not be merged as it is. I added the DO NOT MERGE label and moved the PR to draft.
Of course, there are the temporary dogfooding pins that will be removed before merge.
But also

  • build-poetry includes config-poetry, that's the default usage we want to validate with the workflow on master
  • config-poetry can be tested as in 09e1bb2, eventually merged on master or not (be careful that poetry install && poetry build may not be correct/accurate is set_project_version() is not in config-poetry. The verify-config-poetry job was ok.
  • 085cd83 should be merged on master (except the lines 32, 33)
  • fix the runs-on: github-ubuntu-latest-s with the latest recommendations in order to validate on the expected runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants