BUILD-8956 Verify config-poetry action#110
Conversation
Add a verify-config-poetry job that exercises the standalone action, and point build-poetry at the feature branch for end-to-end validation.
Replace the separate verify job with an inline config-poetry step ahead of build-poetry in the existing build workflow.
Promote was incrementing the build number in a separate job because get-build-number could not restore the cache from config-poetry.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to dogfood and validate the new config-poetry GitHub Action and to pass the produced build number into the promote job.
Changes:
- Exposes
BUILD_NUMBERas an output from thebuildjob (sourced from theconfig-poetrystep). - Adds
mise-actionsetup and runs the standaloneconfig-poetryaction beforebuild-poetry. - Propagates
BUILD_NUMBERinto thepromotejob environment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| outputs: | ||
| BUILD_NUMBER: ${{ steps.config-poetry.outputs.BUILD_NUMBER }} |
| uses: SonarSource/ci-github-actions/config-poetry@feat/hnasr/BUILD-8956-createConfigPoetry # dogfood | ||
| - uses: SonarSource/ci-github-actions/build-poetry@feat/hnasr/BUILD-8956-createConfigPoetry # dogfood |
Code Review ✅ ApprovedIntegrates the new config-poetry action into the build pipeline and propagates the build number to the promotion job. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
julien-carsique-sonarsource
left a comment
There was a problem hiding this comment.
This PR should not be merged as it is. I added the DO NOT MERGE label and moved the PR to draft.
Of course, there are the temporary dogfooding pins that will be removed before merge.
But also
- build-poetry includes config-poetry, that's the default usage we want to validate with the workflow on master
- config-poetry can be tested as in 09e1bb2, eventually merged on master or not (be careful that
poetry install && poetry buildmay not be correct/accurate isset_project_version()is not in config-poetry. The verify-config-poetry job was ok. - 085cd83 should be merged on master (except the lines 32, 33)
- fix the
runs-on: github-ubuntu-latest-swith the latest recommendations in order to validate on the expected runners



Summary
Dogfood PR to validate the new
config-poetryaction from SonarSource/ci-github-actions#292.poetry installandpoetry buildfeat/hnasr/BUILD-8956-createConfigPoetryfor end-to-end validation through the refactored build actionTest plan
Verify config-poetryjob passes (standalone action + Poetry install/build via Repox)Buildjob passes (build-poetry consuming config-poetry internally)Promotejob passesRevert action refs to
@master/@v1after ci-github-actions#292 is merged.