BUILD-11114 Add utility math functions

[CristianAmbrosini]

No description provided.

[sonar-review-alpha]

Summary

Adds four utility math functions: multiply(), divide() with zero-check protection, is_even() for parity testing, and clamp() to bound values within a range. These are self-contained helper functions with no external dependencies.

What reviewers should know

Start here: Each function is independent and straightforward — verify the logic matches expected behavior for basic math operations.

Key points:

• divide() includes a guard clause for division by zero
• clamp() uses early returns to handle boundary conditions
• All functions handle their intended use cases without side effects
• No imports or state management required

Note: The existing add_one() function returns number + 2 (appears intentional or inherited), not number + 1 — unrelated to this PR but worth being aware of.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[CristianAmbrosini]

Mistake

[hashicorp-vault-sonar-prod]

BUILD-11114

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR adds a small set of math utility functions to sonar_dummy_python_oss, expanding the module beyond the existing add_one helper.

Changes:

• Added multiply(a, b) for multiplication.
• Added divide(a, b) with a division-by-zero guard.
• Added is_even(n) and clamp(value, min_val, max_val) helpers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

divide raises ValueError on division by zero, but native Python division raises ZeroDivisionError. This mismatch can surprise callers who catch ZeroDivisionError (or rely on that standard behavior). Consider raising ZeroDivisionError, or clearly documenting the nonstandard exception type.

Suggested change

	raise ValueError("Cannot divide by zero")
	raise ZeroDivisionError("Cannot divide by zero")

[Copilot]

clamp doesn't validate that min_val <= max_val. If callers pass swapped bounds, the function can return values outside the intended range semantics (or silently mask the error). Consider checking the bound ordering and raising a ValueError when min_val > max_val.

[Copilot]

add_one currently returns number + 2, which is inconsistent with the function name and will produce incorrect results for callers expecting an increment by 1. Either change the implementation to add 1, or rename the function to reflect the actual behavior.

Suggested change

	return number + 2
	return number + 1