-
Notifications
You must be signed in to change notification settings - Fork 523
Add vid/pid of the Schlage Sense Pro to new-matter-lock #2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Invitation URL: |
Test Results 71 files 483 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 595f910. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 595f910 |
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DCL lists 0x3800 for the Schlage Sense Pro - is this pid correct or is this a different model?
| {0x10E1, 0x2002}, -- VDA | ||
| {0x1421, 0x0042}, -- Kwikset Halo Select Plus | ||
| {0x1421, 0x0081}, -- Kwikset Aura Reach | ||
| {0x1236, 0xa538}, -- Kwikset Aura Reach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {0x1236, 0xa538}, -- Kwikset Aura Reach | |
| {0x1236, 0xa538}, -- Schlage Sense Pro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Thank you for checking.
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
Kwang-Hui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Type of Change
Checklist
Description of Change
Summary of Completed Tests