Skip to content

Conversation

@HunsupJung
Copy link
Collaborator

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results

   71 files    483 suites   0s ⏱️
2 497 tests 2 494 ✅ 0 💤 3 ❌
4 286 runs  4 283 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 595f910.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

File Coverage
All files 72%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 65%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 595f910

{0x10E1, 0x2002}, -- VDA
{0x1421, 0x0042}, -- Kwikset Halo Select Plus
{0x1421, 0x0081}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Kwikset Aura Reach
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DCL lists 0x3800 for the Schlage Sense Pro - is this pid correct or is this a different model?

{0x10E1, 0x2002}, -- VDA
{0x1421, 0x0042}, -- Kwikset Halo Select Plus
{0x1421, 0x0081}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Kwikset Aura Reach
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{0x1236, 0xa538}, -- Kwikset Aura Reach
{0x1236, 0xa538}, -- Schlage Sense Pro

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Thank you for checking.

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
Copy link
Contributor

@Kwang-Hui Kwang-Hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants