Support keypair generation for Aliro #2682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 483 suites 0s ⏱️ Results for commit 7a8c775. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7a8c775 |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
force-pushed
the
feature/support-keypair-generation
branch
from
ed58efb to
0cf840f
Compare
Contributor
|
@tpmanley Could you please review this PR? |
tpmanley
reviewed
Jan 26, 2026
| } | ||
| } | ||
| local status = security.generate_self_signed_cert(request_opts) | ||
| local privKey = string.sub(utils.bytes_to_hex_string(status.key_der), PRIV_KEY_START, PRIV_KEY_END) |
Contributor
There was a problem hiding this comment.
If I'm not mistaken, this won't always work because it doesn't take into account that DER uses variable length integers. I think we may need to parse the data in order to accurately extract the desired components.
Collaborator
Author
There was a problem hiding this comment.
Okay, I will change it to extract the desired components accurately.
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
requested review from
Kwang-Hui,
hcarter-775,
nickolas-deboom and
tpmanley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
Summary of Completed Tests