Rework VRChat OSC address/port handling #1701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Type: Bug
Eirenliel
approved these changes
Dec 31, 2025
Member
Eirenliel
left a comment
Eirenliel
left a comment
There was a problem hiding this comment.
I mean it's not really thread safe even with this fix, but like... so is life.
| /** | ||
| * Close/remove the OSCQuery sender | ||
| */ | ||
| fun closeOscQuerySender() { |
Member
There was a problem hiding this comment.
if your addOscQuerySender is synchronized, that should be too, probably.
Member
Author
There was a problem hiding this comment.
Changed to just use VRServer thread, all the rest are on it anyways so we should probably just keep that up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up all the OSC port initialization methods to make them clearer and handle match detection better. OSCQuery detection has also been changed to prioritize an OSCQuery entry that matches the configured IP and/or port. Also prioritized OSCQuery detection over using the manually configured address so there won't be duplicate data sent.
Should fix #1309