Skip to content

Conversation

@Aed-1
Copy link
Member

@Aed-1 Aed-1 commented Dec 19, 2025

adds #1673

clicking the "manual mounting" button makes that modal pop up where you do your stuff, then the "done" button closes the modal and takes you to the next step

image image

@github-actions github-actions bot added Area: GUI Related to the GUI Area: Translation Improvements or additions to translations labels Dec 19, 2025
@Aed-1 Aed-1 requested a review from ImSapphire as a code owner December 26, 2025 02:09
@ImSapphire
Copy link
Member

Doesn't seem to be working quite right for me, when I click on an assignment point the prompt appears behind the Manual Mounting modal: image

@Aed-1
Copy link
Member Author

Aed-1 commented Dec 28, 2025

well thats not supposed to happen..
il look at it later today

@Aed-1 Aed-1 requested a review from loucass003 December 28, 2025 21:29
@ImSapphire
Copy link
Member

On the mobile UI (when the window is too small horizontally), the Done button may be underneath the thigh/ankle assignment points, causing it to be unclickable
image

@Aed-1
Copy link
Member Author

Aed-1 commented Dec 28, 2025

have a go now

Aed-1 and others added 5 commits December 29, 2025 00:13
Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
Aed-1 and others added 3 commits December 29, 2025 00:22
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx

Co-authored-by: Sapphire <imsapphire0@gmail.com>
@ImSapphire
Copy link
Member

ImSapphire commented Dec 29, 2025

hmm, if the user clicks on the Mounting Calibration reset button, then during the countdown goes to Manual mounting and clicks Done, when the automatic mounting calibration finishes it will skip a step. Perhaps the 'Manual mounting' button should be disabled when a reset is pending

@Aed-1
Copy link
Member Author

Aed-1 commented Dec 29, 2025

ive made it so that once you press the mounting reset button, the manual reset button will disable, and ive also made sure it re-enables once the timer is up so that if you decide to go back, the button wont still be disabled

@ImSapphire
Copy link
Member

works great! Only issue I can notice with the Stay Aligned setup flow is that you can click a reset button then go back to previous page which messes up the flow a bit, but it's not caused by this PR nor is it really a big issue

@Aed-1
Copy link
Member Author

Aed-1 commented Dec 29, 2025

if you want i can quickly set the "previous step" button to disabled while resetting but that might be scope creep

@ImSapphire
Copy link
Member

since it's an existing issue I think it's fine to do that in a follow-up

@ImSapphire
Copy link
Member

ImSapphire commented Dec 29, 2025

Found another edge case: click mounting calibration, go to previous step and then click full reset. The 'manual mounting' button stays disabled. I think ResetButton should have an onCancelled callback, so we can do setDisableMounting(false) when the reset is cancelled.

Disabling the 'Previous step' button during the reset would prevent the user from going back and clicking full reset, however resets can also be triggered by other software through SolarXR

@Aed-1
Copy link
Member Author

Aed-1 commented Dec 31, 2025

surely the second option would still be viable as if your triggering resets through a seperate program, there will be no manual mounting button to grey out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: GUI Related to the GUI Area: Translation Improvements or additions to translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants