-
-
Notifications
You must be signed in to change notification settings - Fork 222
add manual mounting to stay alligned setup #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/mounting/ManualMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/mounting/ManualMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
|
well thats not supposed to happen.. |
|
have a go now |
gui/src/components/onboarding/pages/mounting/ManualMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/stay-aligned/stay-aligned-steps/VerifyMounting.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
…steps/VerifyMounting.tsx Co-authored-by: Sapphire <imsapphire0@gmail.com>
|
hmm, if the user clicks on the Mounting Calibration reset button, then during the countdown goes to Manual mounting and clicks Done, when the automatic mounting calibration finishes it will skip a step. Perhaps the 'Manual mounting' button should be disabled when a reset is pending |
|
ive made it so that once you press the mounting reset button, the manual reset button will disable, and ive also made sure it re-enables once the timer is up so that if you decide to go back, the button wont still be disabled |
|
works great! Only issue I can notice with the Stay Aligned setup flow is that you can click a reset button then go back to previous page which messes up the flow a bit, but it's not caused by this PR nor is it really a big issue |
|
if you want i can quickly set the "previous step" button to disabled while resetting but that might be scope creep |
|
since it's an existing issue I think it's fine to do that in a follow-up |
|
Found another edge case: click mounting calibration, go to previous step and then click full reset. The 'manual mounting' button stays disabled. I think Disabling the 'Previous step' button during the reset would prevent the user from going back and clicking full reset, however resets can also be triggered by other software through SolarXR |
|
surely the second option would still be viable as if your triggering resets through a seperate program, there will be no manual mounting button to grey out |


adds #1673
clicking the "manual mounting" button makes that modal pop up where you do your stuff, then the "done" button closes the modal and takes you to the next step