Migrate core/dev.slimevr.protocol to Kotlin #1688
Open
+1,756
−1,959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
many imports instead of wildcard importing woo
JovannMC
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
github-actions
bot
added
Area: SteamVR Driver
loucass003
reviewed
Dec 18, 2025
server/core/src/main/java/dev/slimevr/protocol/datafeed/DataFeedHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/datafeed/DataFeedBuilder.kt
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Area: Application Protocol
JovannMC
force-pushed
the
maya/migration/protocol
branch
from
0fff98b to
01c0978
Compare
loucass003
approved these changes
Dec 18, 2025
ButterscotchV
requested changes
Dec 26, 2025
Member
ButterscotchV
left a comment
ButterscotchV
left a comment
There was a problem hiding this comment.
There's probably a couple other redundant usages of !!, but these are the worst. Once these are fixed I think it's good. I agree the top level functions for the builders are probably best.
server/core/src/main/java/dev/slimevr/protocol/rpc/serial/RPCSerialHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/reset/RPCResetHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/serial/RPCProvisioningHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/rpc/serial/RPCSerialHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/datafeed/DataFeedHandler.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/protocol/pubsub/PubSubHandler.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
ButterscotchV
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of many PRs to migrate the core server to Kotlin - migrated core/dev.slimevr.protocol
Mostly used IntelliJ's convert tool with manual changes, seems to work from basic testing but should probably be tested/reviewed more extensively