🧪 Add test for run_thrust_simulation in QAG_Truth.ipynb#7
🧪 Add test for run_thrust_simulation in QAG_Truth.ipynb#7Sir-Ripley wants to merge 1 commit intomainfrom
Conversation
This commit introduces a unit test for the `run_thrust_simulation` function in `QAG_Truth.ipynb` to ensure reliability and output consistency. Key changes: - Corrected `importimport` typo in the notebook's first code cell. - Updated `run_thrust_simulation` to return the calculated `d_retrocausal[-1]` value for programmatic testing. - Added `test_thrust_consistency()` which verifies numerical accuracy (~7713.34) and positive scaling of displacement with psychon input. - Integrated the test into the notebook's main execution block. These changes improve the testability of the QAG propulsion model and provide a regression baseline for future modifications. Co-authored-by: Sir-Ripley <31619989+Sir-Ripley@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's GuideAdds a small testing harness around the QAG propulsion thrust simulation by fixing a syntax error, making run_thrust_simulation return its final displacement, and introducing a notebook-local unit test that validates both scaling behavior and a fixed expected value, which is invoked from the main execution block. Sequence diagram for QAG main execution and thrust test invocationsequenceDiagram
participant Main as main_block
participant Test as test_thrust_consistency
participant Sim as run_thrust_simulation
Main->>Test: call test_thrust_consistency
Test->>Sim: run_thrust_simulation(5400.0)
Sim-->>Test: d1 (final_displacement)
Test->>Sim: run_thrust_simulation(10800.0)
Sim-->>Test: d2 (final_displacement)
Test->>Test: assert d2 > d1
Test->>Test: assert abs(d1 - 7713.3436) < 0.01
Test-->>Main: test completed
Main->>Sim: run_thrust_simulation(5400.0)
Sim-->>Main: displacement
Main->>Main: run_galactic_theater(1.0)
Main->>Main: run_stress_test(5400.0)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces automated testing for the QAG propulsion simulation logic within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hard-coding the expected displacement
7713.3436insidetest_thrust_consistencymakes the test brittle; consider deriving this from the same constants/parameters used in the simulation or at least grouping such reference values in a single place so they’re easier to update if the model changes. - Automatically running
test_thrust_consistency()in the__main__execution block may not always be desirable for interactive or exploratory notebook runs; consider gating it behind a flag or separate entry point so the simulation can be run without tests when needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hard-coding the expected displacement `7713.3436` inside `test_thrust_consistency` makes the test brittle; consider deriving this from the same constants/parameters used in the simulation or at least grouping such reference values in a single place so they’re easier to update if the model changes.
- Automatically running `test_thrust_consistency()` in the `__main__` execution block may not always be desirable for interactive or exploratory notebook runs; consider gating it behind a flag or separate entry point so the simulation can be run without tests when needed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a unit test for the run_thrust_simulation function, which is a valuable addition for ensuring the simulation's reliability. The changes include fixing a minor syntax error, refactoring the function to return its result, and adding the test case itself. My review includes suggestions to make the new test more robust by verifying the scaling behavior more strictly, and to remove a redundant function call from the main execution block to improve clarity.
| "def test_thrust_consistency():\n", | ||
| " print(\"--- RUNNING QAG THRUST CONSISTENCY TEST ---\")\n", | ||
| " d1 = run_thrust_simulation(5400.0)\n", | ||
| " d2 = run_thrust_simulation(10800.0)\n", | ||
| " \n", | ||
| " # Verify that doubling psychon increases displacement (it scales linearly with qid_scale)\n", | ||
| " assert d2 > d1, \"Displacement should increase with psychon count\"\n", | ||
| " \n", | ||
| " # Fixed point check for 5400.0 psychon_ug\n", | ||
| " # Formula derived expected value: ~7713.34\n", | ||
| " assert abs(d1 - 7713.3436) < 0.01, f\"Expected ~7713.34, got {d1:.2f}\"\n", | ||
| " \n", | ||
| " print(\"TEST PASSED: Thrust displacement consistency verified.\")\n", |
There was a problem hiding this comment.
The new test function test_thrust_consistency is a great addition for ensuring the simulation's correctness. To make it more robust, you could strengthen the scaling assertion. The current check assert d2 > d1 is good, but since the displacement has an affine relationship with psychon_ug (of the form d = k * psychon_ug + c), you can verify this more strictly by checking if the displacement increase is constant for a constant increase in input.
Also, consider extracting magic numbers like 5400.0 and 7713.3436 into named constants to improve readability. I've omitted that from the code suggestion below to keep the line count consistent with the original code block.
Here's a suggested implementation that strengthens the test logic:
def test_thrust_consistency():
print("--- RUNNING QAG THRUST CONSISTENCY TEST ---")
d0 = run_thrust_simulation(0.0)
d1 = run_thrust_simulation(5400.0)
d2 = run_thrust_simulation(10800.0)
# Verify monotonic increase and affine scaling
assert d2 > d1 > d0, "Displacement should increase with psychon count"
assert abs((d1 - d0) - (d2 - d1)) < 0.01, "Displacement scaling is not affine"
# Fixed point check for 5400.0 psychon_ug
assert abs(d1 - 7713.3436) < 0.01, f"Expected ~7713.34, got {d1:.2f}"
print("TEST PASSED: Thrust displacement consistency verified.")
| " print(\"\\n--- INITIALIZING QAG MASTER SIMULCAST ---\\n\")\n", | ||
| " test_thrust_consistency()\n", | ||
| " run_galactic_theater(1.0)\n", | ||
| " run_thrust_simulation(5400.0)\n", |
There was a problem hiding this comment.
The test_thrust_consistency() function, which is called on line 211, already executes run_thrust_simulation(5400.0) as part of its internal checks. This makes the subsequent call to run_thrust_simulation(5400.0) on this line redundant. Removing this call will clean up the execution flow and avoid duplicate output from the simulation.
1 participant
I have implemented a unit test for the
run_thrust_simulationfunction inQAG_Truth.ipynb.🎯 What: The testing gap for the propulsion simulation was addressed by refactoring the simulation function and adding automated consistency checks.
📊 Coverage:
run_thrust_simulationproduces the expected displacement (~7713.34) for default parameters.importimport).✨ Result: Improved reliability and automated verification of the QAG propulsion logic within the notebook.
PR created automatically by Jules for task 15320882876725388340 started by @Sir-Ripley
Summary by Sourcery
Add an automated consistency check for the QAG propulsion thrust simulation and integrate it into the notebook’s main execution flow.
Bug Fixes:
Enhancements:
Tests: