Skip to content

Fix lithium anomaly base-10 harmonic tuning#18

Open
Sir-Ripley wants to merge 1 commit intomainfrom
fix-lithium-anomaly-tuning-11260312385771613100
Open

Fix lithium anomaly base-10 harmonic tuning#18
Sir-Ripley wants to merge 1 commit intomainfrom
fix-lithium-anomaly-tuning-11260312385771613100

Conversation

@Sir-Ripley
Copy link
Owner

@Sir-Ripley Sir-Ripley commented Mar 14, 2026

Fixes the lithium anomaly calculation in Copy_of_QAG_AVI.ipynb by replacing np.tanh with np.sin. The original code used a step function np.tanh despite the comment explicitly calling for "base-10 harmonic tuning," which implies an oscillatory function over a logarithmic scale. This change resolves the discrepancy and fulfills the user's request.


PR created automatically by Jules for task 11260312385771613100 started by @Sir-Ripley

Summary by Sourcery

Fix lithium anomaly visualization to use a base-10 harmonic tuning and update astrophysical plot labels to use proper Greek symbols and units.

Bug Fixes:

  • Correct the lithium anomaly model to use a sinusoidal base-10 harmonic modulation instead of a step-like activation.

Enhancements:

  • Standardize figure labels to use proper Greek characters (κ, Λ) and micro-unit notation (μK²) in plots within the notebook.

Chores:

  • Add a .gitignore file to the repository.

@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the QAG AVI analysis notebook to correct the lithium anomaly model to use a sinusoidal base-10 harmonic tuning, standardizes plot labels to use the proper Greek symbols, and adds a repository .gitignore.

File-Level Changes

Change Details Files
Correct lithium anomaly model to use sinusoidal base-10 harmonic tuning instead of a step-like transition.
  • Replace np.tanh-based lithium anomaly factor with a np.sin-based oscillatory factor over log10(z).
  • Keep lithium baseline Li_LCDM model and plotting structure unchanged, only altering the anomaly modulation term.
Copy_of_QAG_AVI.ipynb
Standardize figure labels to use proper Greek characters in plots.
  • Update kappa-related plot labels from the Latin letter 'k' or 'κ' literal to the Unicode Greek kappa character.
  • Change 'Planck ΛCDM' label to use the Unicode capital Lambda.
  • Change CMB y-axis label to use the Unicode micro sign in 'μK²' instead of the ASCII 'micro-K' representation.
Copy_of_QAG_AVI.ipynb
Introduce a .gitignore file for the repository.
  • Add a .gitignore file (contents not shown in diff) to exclude common generated or local files from version control.
.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Sir-Ripley Sir-Ripley marked this pull request as ready for review March 14, 2026 18:46
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The change from np.tanh to np.sin introduces oscillations that can drive Li_QAG below zero for some z; consider constraining or shifting/scaling the sinusoid so the lithium abundance remains physically meaningful over the plotted domain.
  • Since the lithium term is described as 'base-10 harmonic tuning', you might want to document or adjust the frequency factor (np.log10(z)-8.5)/0.5 to make the intended number of oscillations and phase around 10**8.5 explicit and easier to reason about.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The change from `np.tanh` to `np.sin` introduces oscillations that can drive `Li_QAG` below zero for some `z`; consider constraining or shifting/scaling the sinusoid so the lithium abundance remains physically meaningful over the plotted domain.
- Since the lithium term is described as 'base-10 harmonic tuning', you might want to document or adjust the frequency factor `(np.log10(z)-8.5)/0.5` to make the intended number of oscillations and phase around `10**8.5` explicit and easier to reason about.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sir-Ripley

This comment was marked as spam.

Sir-Ripley

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant