Re-implement FabricShaderProgram for mods that use it #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. Satin (API) Signed-off-by: unilock <unilock@fennet.rentals>
Su5eD
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. Satin API
The
<init>method originally usedname.toString(), so it was adjusted to just use NeoForge's method instead, which already takes aResourceLocation.(this is enough to get Satin API working! although it seems to have issues with ModernFix's Dynamic Resources)
EDIT: This PR is NOT enough to get Satin API working; I'm not sure why I said that :p
Some mixins still fail; I've worked around them all in one of my "modpack tweaks" mods: https://github.com/unilock/sheepish