Skip to content

Conversation

@unilock
Copy link
Contributor

@unilock unilock commented Dec 11, 2024

Fixes a crash with Blockus, and probably other mods

Signed-off-by: unilock <unilock@fennet.rentals>
@unilock
Copy link
Contributor Author

unilock commented Dec 12, 2024

Hm, that's not right... (these blocks / items don't have their colors applied both in the inventory and when placed in-world)

image

(better than crashing whenever the item is rendered though)

@Su5eD Su5eD added bug Something isn't working needs info Further information is requested labels Dec 13, 2024
unilock added a commit to unilock/sheepish that referenced this pull request Mar 30, 2025
Signed-off-by: unilock <unilock@fennet.rentals>
@unilock
Copy link
Contributor Author

unilock commented May 7, 2025

ColorProviderRegistryImpl#get appears to be returning null for vanilla blocks / items?

EDIT: Further discussion in the Sinytra Discord guild: https://discord.com/channels/1141048834177388746/1141070334733328477/1369468740680421396

@unilock
Copy link
Contributor Author

unilock commented Jun 13, 2025

Implemented in #230

@unilock unilock closed this Jun 13, 2025
@unilock unilock deleted the 1.21.1-fabric-rendering-mixins branch December 11, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs info Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants