Decouple NER tag vocab from torchtext and add conversion CLI#11
Open
codex-corp wants to merge 1 commit intoSinaLab:mainfrom
Open
Decouple NER tag vocab from torchtext and add conversion CLI#11codex-corp wants to merge 1 commit intoSinaLab:mainfrom
codex-corp wants to merge 1 commit intoSinaLab:mainfrom
Conversation
Ref: SinaLab#10 - add sinatools/ner/tag_vocab.py with shims that load legacy torchtext pickles and re‑serialize them into the native Vocab class (lazy-imported to avoid circular deps) - switch sinatools/ner/__init__.py and helpers.py to use the new loader so the runtime works without torchtext - expose a convert_tag_vocab console script (and register it in setup.py) to rewrite checkpoints in place for updated environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #10
Solution: #10 (comment)
add sinatools/ner/tag_vocab.py with shims that load legacy torchtext pickles and re‑serialize them into the native Vocab class (lazy-imported to avoid circular deps)
switch sinatools/ner/init.py and helpers.py to use the new loader so the runtime works without torchtext
expose a convert_tag_vocab console script (and register it in setup.py) to rewrite checkpoints in place for updated environments