Conversation
* Rename torchjd to TorchJD when referring to the repo * Fix typo * Restructure the file * Add explanation about PYTHONPATH * Suggest rm -f for uv.lock (otherwise we often have a warning saying the file doesn't exist) * Add tip about code coverage * Change desired code coverage value from ~95-100% to 100%. Also explain that we appreciate PRs with insufficient coverage. * Fix outdated example with import from device.py * Improve explanation of partial functions to create tensors * Add README verification step in the release section
ValerianRey
added
the
cc: docs
Contributor
Author
|
@PierreQuinton should be smoother now. Nothing to change on your end I think. |
Contributor
Author
|
@claude Please review this. In particular, check for typos in the entire CONFIGURING.md file, even in parts of the file that this PR doesn't touch. Also check that nothing that is said here is outdated. |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.