refactor(autogram): Remove vmap rule generation#462
Open
ValerianRey wants to merge 4 commits intomainfrom
Open
refactor(autogram): Remove vmap rule generation#462ValerianRey wants to merge 4 commits intomainfrom
ValerianRey wants to merge 4 commits intomainfrom
Conversation
ValerianRey
added
cc: refactor
ValerianRey
added
cc: refactor
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 51 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
I added this when we where having 2 engines on the same modules. This is because the forward was then run using vmap with the functional api. This is exactly what we lose with this change (but I don't have anything against it). |
PierreQuinton
approved these changes
Oct 18, 2025
Contributor
Author
|
Ok, then I'm not sure this PR is such a good idea. I'm gonna keep this open for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what I'm doing here, but as far as I understand, the generated vmap rule for JacobianAccumulator is never used.
I think (correct me if I'm wrong) that it would only be used if we vmapped the forward pass of a hooked model.
And I don't think we will ever cover that case (it's just too much work for nothing it seems).
So this is 1 less line of code, one less non-tested feature, and maybe even a lighter JacobianAccumulator node.