Issue 449: fix various equality comparisons#450
Merged
jorisv merged 3 commits intoSimple-Robotics:develfrom Feb 20, 2026
Merged
Issue 449: fix various equality comparisons#450jorisv merged 3 commits intoSimple-Robotics:develfrom
jorisv merged 3 commits intoSimple-Robotics:develfrom
Conversation
jorisv
requested changes
Feb 19, 2026
Contributor
jorisv
left a comment
jorisv
left a comment
There was a problem hiding this comment.
Hello,
Thanks for the contribution.
I don't think we need to add tests for the equality operator.
jorisv
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #449.
I haven't added any tests around this; it might become a little bit of a burden to maintain exhaustive tests comparing the equality of every possible field. But there's also a middle ground where we test a few "obvious" comparisons. Let me know what you think; I'd be happy to add some, but I also think these changes are fairly self-explanatory.
AI disclaimer: I discovered these issues by letting Claude (with Opus 4.6) poke around the repo looking for obvious bugs/inconsistencies.