Make expiring offline tokens the default configuration #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzooeeyy
commented
Nov 19, 2025
zzooeeyy
commented
Nov 19, 2025
| config.embedded_app = true | ||
| config.after_authenticate_job = false | ||
| config.api_version = ShopifyAPI::AdminVersions::LATEST_SUPPORTED_ADMIN_VERSION | ||
| config.api_version = "2025-10" |
Contributor
Author
There was a problem hiding this comment.
Unsure about this change, but ShopifyAPI::AdminVersions::LATEST_SUPPORTED_ADMIN_VERSION has been deprecated from the latest version
Contributor
There was a problem hiding this comment.
Thanks! This is correct!
zzooeeyy
changed the title
lizkenyon
approved these changes
Nov 27, 2025
| config.embedded_app = true | ||
| config.after_authenticate_job = false | ||
| config.api_version = ShopifyAPI::AdminVersions::LATEST_SUPPORTED_ADMIN_VERSION | ||
| config.api_version = "2025-10" |
Contributor
There was a problem hiding this comment.
Thanks! This is correct!
zzooeeyy
changed the title
zzooeeyy
force-pushed
the
zl/default-to-expiring-offline-tokens
branch
from
51357d1 to
a4ffd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
shopify-api-rubygem after this change:shopify_appgem after this change:WHAT is this pull request doing?