Open
Conversation
This allows lock messages to be displayed as warnings in the banner without actually locking deploys.
mdeloupy
commented
Jun 11, 2019
mdeloupy
commented
Jun 11, 2019
byroot
reviewed
Jun 11, 2019
Contributor
byroot
left a comment
byroot
left a comment
There was a problem hiding this comment.
It's a good start, but there's likely some missing changes in view code.
One I can think of the the browser extension controller here:
it renders a template based on thestack.merge_status, so I think it wouldn't display the "advisory lock" at all right now.
byroot
reviewed
Jun 11, 2019
eapache
reviewed
Jun 12, 2019
| lock_reason.present? && lock_level != LOCK_LEVEL_ADVISORY | ||
| end | ||
|
|
||
| def soft_locked? |
Contributor
There was a problem hiding this comment.
It's not clear to me without looking at the implementation whether soft_locked? means "locked, and level == advisory", or just "locked, and level is at least advisory".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows lock messages to be displayed as warnings in the banner without actually
locking deploys.